fix: adapt to compose-go v2.16.1 promoting x-initialSync silently - #14281
Merged
Merged
Conversation
docker-agent
reviewed
Oct 1, 2026
docker-agent
left a comment
docker-agent
left a comment
Contributor
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
ndeloof
previously approved these changes
Oct 1, 2026
ndeloof
left a comment
ndeloof
left a comment
Contributor
There was a problem hiding this comment.
LGTM
We can also drop management of x-develop in docker/compose codebase
compose-go's loader now silently renames both deprecated x-initialSync and x-develop extensions to their official initial_sync and develop attributes before compose ever sees them as extensions, so the legacy lookups and deprecation warnings for both can no longer be reached. That's why the e2e test asserting on the x-initialSync warning broke under the bump. Simplify both lookups to rely on the promoted fields directly, and rewrite the e2e test to check the legacy attribute still triggers a real initial sync instead of asserting on an unreachable message. Signed-off-by: Guillaume Lours <glours@users.noreply.github.com>
glours
force-pushed
the
fix/compose-go-2.16.1-x-initial-sync
branch
from
October 1, 2026 14:33
769848d to
97357b1
Compare
docker-agent
reviewed
Oct 1, 2026
docker-agent
left a comment
docker-agent
left a comment
Contributor
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
ndeloof
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Fixes the e2e CI failures caused by dependabot's
compose-gov2.16.1 bump:its loader now silently promotes the deprecated
x-initialSyncextension tothe official
initial_syncattribute, which made our legacy warning codedead and broke the test asserting on it.
Related issue
Closes #14278 replaces that dependabot PR, which failed CI, with this
manual fix.