vendor: github.com/klauspost/compress v1.20.1 - #7308
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
docker-agent
left a comment
docker-agent
left a comment
Contributor
There was a problem hiding this comment.
⚠️ Review incomplete
chunk 1: Drafter did not complete
Findings so far:
vvoland
previously approved these changes
Sep 15, 2026
- Add lzw reader/writer - ci: test against go1.27.x, drop go1.24.x - flate: Writer L7-9 with dictionary can emit the dictionary to stream - gzhttp: limit jitter hash to jitterBuffer bytes - s2: arm64 assembly encoders, lowered from the amd64 avo program - s2: clamp the Go EncodeBetter skip to match the assembly - xpress: add Microsoft XPRESS (MS-XCA) decompression - xxhash: bound input of non-preemptive assembly - zstd, huff0: improved arm64 lowering, and narrow two table loads to MOVWQZX - zstd/huff0: break false partial-register dependencies in seqdec/4X decoders - zstd/huff0: fold two ISA-gap x86 idioms in the avo arm64 lowering full diff: klauspost/compress@v1.19.2...v1.20.0 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
full diff: klauspost/compress@v1.20.0...v1.20.1 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
bump_compress
branch
from
October 1, 2026 17:34
918127e to
07339fa
Compare
thaJeztah
changed the title
vvoland
approved these changes
Oct 1, 2026
docker-agent
reviewed
Oct 1, 2026
docker-agent
left a comment
docker-agent
left a comment
Contributor
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
This is a routine vendor bump of github.com/klauspost/compress from v1.19.2 to v1.20.1. The changes are upstream library updates (two releases), consisting primarily of auto-generated ARM64 assembly refactoring, xxhash bounds-checking improvements, and related Go-side wrapper updates. No bugs were introduced in the added lines.
Lower-confidence observations (unverified, low severity — not blocking)
- [low]
vendor/github.com/klauspost/compress/zstd/seqdec_arm64.s:1591 —sequenceDecs_decodeSync_arm64: seqSize tracking moved from per-iteration accumulation to a single end-of-loop delta; error-exit paths now return seqSize=0. This appears intentional (callers should not rely on partial seqSize on error), but is a behavioral change worth noting. - [low]
vendor/github.com/klauspost/compress/zstd/seqdec_arm64.s:1597 — Same behavioral change applies to the safe variant (sequenceDecs_decodeSync_safe_arm64). - [low]
vendor/github.com/klauspost/compress/zstd/seqdec_arm64.s:1586 — Non-safe copy-literals fast path performs an unconditional 16-byte load/store even when literal count is zero; the safe variant retains an explicit guard. This is a known upstream pattern (non-safe paths trade safety for speed) and is not a practical bug in normal use.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vendor: vendor: github.com/klauspost/compress v1.20.1
full diff: klauspost/compress@v1.20.0...v1.20.1
vendor: github.com/klauspost/compress v1.20.0
full diff: klauspost/compress@v1.19.2...v1.20.0
Summary
Release notes (optional)
A picture of a cute animal (not mandatory but encouraged)