Skip to content

Preserve advanced fan mode across user mode changes #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DKalimist wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Preserve advanced fan mode across user mode changes #327

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/operate.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,8 +416,16 @@ void Operate::setUserMode(user_mode userMode) const {
if (msiEcHelper.hasShiftMode()) {
msiEcHelper.setShiftMode(shiftMode);
}

if (msiEcHelper.hasFanMode()) {

// Custom fan curve (advanced mode) is orthogonal to the shift/user mode.
// Don't stomp it back to auto here - the UI resyncs the mode radio buttons
// (MainWindow::updateUserMode) right after settings are restored on startup,
// which re-enters this function and would otherwise silently drop advanced mode.
bool keepAdvanced = userMode != user_mode::silent_mode &&
msiEcHelper.hasFanMode() &&
getFanMode() == fan_mode::advanced_fan_mode;

if (msiEcHelper.hasFanMode() && !keepAdvanced) {
msiEcHelper.setFanMode(fanMode);
}

Expand Down