Skip to content

GitHub Workflow: Clean up CI workflow to avoid redundant work. - #655

Merged
KimonHoffmann merged 6 commits into
dmf-mxl:mainfrom
KimonHoffmann:feature/workflow_orthogonalization
Oct 13, 2026
Merged

KimonHoffmann merged 6 commits into
dmf-mxl:mainfrom
KimonHoffmann:feature/workflow_orthogonalization

Conversation

@KimonHoffmann

@KimonHoffmann KimonHoffmann commented Aug 6, 2026 •

Copy link
Copy Markdown
Collaborator

Orthogonalize the CI workflow by separating out redundant steps that were previously lumped in with other variations.

Details

Backport requirements

None.
Beneficial to have on all active branches, so labels have been added accordingly.

Notes

Once this branch has been merged it is important to update the PR merge requirements & status checks for the newly structured CI steps (which is why this PR currently claims that 6 status checks are missing).

@KimonHoffmann
KimonHoffmann force-pushed the feature/workflow_orthogonalization branch 15 times, most recently from 1c87679 to 429baf4 Compare August 6, 2026 14:46
@KimonHoffmann KimonHoffmann linked an issue Aug 6, 2026 that may be closed by this pull request
@felixpou felixpou linked an issue Aug 6, 2026 that may be closed by this pull request
@felixpou felixpou mentioned this pull request Aug 6, 2026
@felixpou felixpou linked an issue Aug 6, 2026 that may be closed by this pull request
@KimonHoffmann
KimonHoffmann force-pushed the feature/workflow_orthogonalization branch 7 times, most recently from b7dbf21 to 4ba642c Compare August 7, 2026 10:22
@KimonHoffmann KimonHoffmann changed the title WIP: GitHub Workflow: Clean up CI workflow to avoid redundant work. GitHub Workflow: Clean up CI workflow to avoid redundant work. Aug 7, 2026
@vt-tv vt-tv moved this to In progress in MXL TSC Board Aug 20, 2026
@KimonHoffmann

Copy link
Copy Markdown
Collaborator Author

I'm not a github action expert by any means but I can't seem to find when/how the new reuse.yml workflow is invoked. I don't see any trace of it in the build logs.

It is (now) a separate workflow with its separate trigger that runs independently of the CI build.

See
Bildschirmfoto 2026-09-01 um 12 48 24

@KimonHoffmann

Copy link
Copy Markdown
Collaborator Author

See also:
Bildschirmfoto 2026-09-01 um 12 50 48

@vt-tv vt-tv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. LGTM

@vt-tv

vt-tv commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

@KimonHoffmann should we backport to 1.1 or focus only on main? if so, please add the required labels.

@KimonHoffmann

Copy link
Copy Markdown
Collaborator Author

@KimonHoffmann should we backport to 1.1 or focus only on main? if so, please add the required labels.

We could, yes. I'll add the labels accordingly.

@KimonHoffmann KimonHoffmann added backport/v1.0 This PR should be back ported to the release branch of version 1.0. backport/v1.1 This PR should be back ported to the release branch of version 1.1. labels Sep 3, 2026
Comment thread .github/workflows/build.yml
Comment thread .github/workflows/build.yml
Comment thread .github/workflows/build.yml Outdated
Comment thread .github/workflows/build.yml Outdated
@KimonHoffmann
KimonHoffmann force-pushed the feature/workflow_orthogonalization branch from 4ba642c to 0b9c7bf Compare September 9, 2026 15:10

@jonasohland jonasohland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vt-tv

vt-tv commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

@KimonHoffmann DCO issues on some commits.

@KimonHoffmann

KimonHoffmann commented Oct 1, 2026 •

Copy link
Copy Markdown
Collaborator Author

@KimonHoffmann DCO issues on some commits.

Ah, yes thank you. Fixed.

Please note that I didn't yet merge the PR, because we need to coordinate this with the required PR status checks, as you can see above where it claims that there are "6 [status checks] expected" that did not yet complete.

The reason for this is that the jobs changed and the 6 checks refer to the old set of jobs. I'd propose we do this all at once as part of today's TSC meeting so that everyone can rebase their PRs accordingly.

@KimonHoffmann
KimonHoffmann force-pushed the feature/workflow_orthogonalization branch 2 times, most recently from 3ebef61 to 6517b52 Compare October 1, 2026 07:47
@jonasohland

Copy link
Copy Markdown
Contributor

@KimonHoffmann is this ready to be merged?

@KimonHoffmann

Copy link
Copy Markdown
Collaborator Author

Yes I'll merge it this week.
I was a bit reluctant as this will change the required checks for PRs and thus needs a rebase/merge of every open PR. But since this is an inconvenience that won't magically go away it as good a time as any to take that plunge.

Signed-off-by: Kimon Hoffmann <Kimon.Hoffmann@lawo.com>
Signed-off-by: Kimon Hoffmann <Kimon.Hoffmann@lawo.com>
…tectures.

Signed-off-by: Kimon Hoffmann <Kimon.Hoffmann@lawo.com>
Signed-off-by: Kimon Hoffmann <Kimon.Hoffmann@lawo.com>
Signed-off-by: Kimon Hoffmann <Kimon.Hoffmann@lawo.com>
@KimonHoffmann
KimonHoffmann force-pushed the feature/workflow_orthogonalization branch from 6517b52 to 8fa7fb5 Compare October 13, 2026 12:21
Signed-off-by: Jonas Ohland <jonas.ohland@gmail.com>
@KimonHoffmann
KimonHoffmann merged commit 3ddaaa2 into dmf-mxl:main Oct 13, 2026
@github-project-automation github-project-automation Bot moved this from In progress to Done in MXL TSC Board Oct 13, 2026
@backport-mxl-pull-requst

Copy link
Copy Markdown

Backport failed for release/v1.0, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release/v1.0
git worktree add -d .worktree/backport/655/-/release/v1.0 origin/release/v1.0
cd .worktree/backport/655/-/release/v1.0
git switch --create backport/655/-/release/v1.0
git cherry-pick -x 47595150a308c1efe24d7ba5009d1878905fb0d5 cf00f3bfcf5e5599b65dc13b1bc648677b8636a4 11529690bc18e725dc8105510f561d1e3f387536 b9531641d3a0253a10850640a246e98ea8ddc08c 8fa7fb5e5f58cce6e25b14b3df54bfdf7eabc3eb 784280bdeed1aaaa3bade31d61fb193752c738b2

@backport-mxl-pull-requst

Copy link
Copy Markdown

Successfully created backport PR for release/v1.1:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport/v1.0 This PR should be back ported to the release branch of version 1.0. backport/v1.1 This PR should be back ported to the release branch of version 1.1.

Projects

Status: Done

3 participants