Say when the statuses upgrade goes, not that it could have gone already - #190
Merged
Merged
Conversation
The sunset condition it shipped with — both records that predated #181 having run it — was met about an hour after it was written, so the marker started reporting a removal that was not going to happen. A marker stating a condition it does not mean is the thing it exists to prevent, one level up. Pinned to 1.0.0 instead. More records are coming onto luria before the first stable release and each of them predates #181, so the version is the honest gate; a list of projects is never finished at the moment you read it. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YP4P3m8rzVFb8idnTE4FfT
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of the draft #189 so the false nag stops now. The removal itself stays pinned there.
luria upgrade statusesshipped with this sunset condition:Which came true about an hour after it was written — luria's own record ran it on 0.10.0, and dmarx/anthology-of-the-sota#25 ran it on the same release. So
spent-upgradesbegan reporting a removal that is not going to happen, on everyluria lintrun, in both records.A marker stating a condition it does not mean is exactly the failure it exists to prevent, one level up.
Repinned to 1.0.0. More records are coming onto luria before the first stable release —
mathematics-of-meaningandstrata-gare next — and each of them predates #181, so the command still has work. The gate is the version rather than a list of projects because a list is never finished at the moment you read it.The finding also reads better for it:
rather than the old "delete it once every record has run it (…)", which buried the condition in a parenthesis after asserting the wrong thing.
Checks
python -m pytest tests -q: 908 passed.luria lint: clean; thespent-upgradesrow now states a condition that is actually open.🤖 Generated with Claude Code
https://claude.ai/code/session_01YP4P3m8rzVFb8idnTE4FfT
Generated by Claude Code