Repository navigation
Windows: Skip 3 .sh 'compilable' tests depending on nm, if nm isn't in PATH - #23873
Merged
Merged
Conversation
kinke
force-pushed
the
test_win_nm
branch
2 times, most recently
from
September 17, 2026 23:36
32da073 to
11b13b8
Compare
kinke
commented
Sep 17, 2026
| obj_file="${RESULTS_TEST_DIR}/d/${TEST_NAME}_0${OBJ}" | ||
|
|
||
| # ensure no ModuleInfo or TypeInfo related code was generated | ||
| if ! nm "$1" | grep -q 'ModuleInfo\|_d_dso_registry\__start_minfo\|__stop_minfo\|TypeInfo' ; then |
Contributor
Author
There was a problem hiding this comment.
$1 is a path to a *.d.out file, apparently a text file containing the command-line for the earlier compiler run. So this verify_symbols.sh step was totally broken, just not failing because any nm error (incl. not in PATH) was ignored and treated as 'hey, the symbol is not there!'.
…n PATH Seems like the Windows CI runners have a compatible `nm` tool in PATH, so that we haven't seen any failures yet. But users might not have it, so just skip these tests (but only on Windows) checking object-file symbols.
kinke
commented
Sep 17, 2026
kinke
marked this pull request as ready for review
September 18, 2026 00:07
kinke
marked this pull request as draft
September 18, 2026 13:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seems like the Windows CI runners have a compatible
nmtool in PATH, so that we haven't seen any failures yet. But users might not have it (#23870 (comment)), so just skip these tests (but only on Windows) checking object-file symbols.