Skip to content

task-observer: deep-review updates from 2026-05-01#2

Open
divad12 wants to merge 1 commit intomasterfrom
task-observer/deep-review-2026-05-01
Open

task-observer: deep-review updates from 2026-05-01#2
divad12 wants to merge 1 commit intomasterfrom
task-observer/deep-review-2026-05-01

Conversation

@divad12
Copy link
Copy Markdown
Owner

@divad12 divad12 commented May 1, 2026

Target\nskill: .agents/skills/deep-review/SKILL.md\n\n## Observations addressed\n- Observation 001 (journology/log.md): /simplify unavailable leaves no fallback → changed: added explicit fallback: run manual simplify pass inline and note in summary that the dedicated skill was unavailable\n- Observation 005 (journology/log.md): reviewer-override block has no inverse rule for explicitly de-scoped capabilities → changed: added admissibility check (step 3 item 2) before categorization that drops findings targeting project-excluded capabilities; added PROJECT DE-SCOPING RULES injection into all Claude Code independent reviewer dispatches\n- Observation 007 (journology/log.md): uncommitted diff recipe omits untracked new files → changed: Step 1 now captures $UNTRACKED via git ls-files --others --exclude-standard; Claude Code dispatches generate /tmp/deep-review-untracked.patch and include it in the reviewer prompt\n- Observation 008 (journology/log.md): base branch hard-coded as main breaks repos with different integration branches → changed: Step 1 now detects $BASE_BRANCH from project docs (PROGRESS.md, AGENTS.md) before falling back to main; all main..HEAD / main...HEAD references updated to use ${BASE_BRANCH}


Generated by Claude Code

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6b27c1900e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +39 to +40
| grep -oE '`[a-zA-Z0-9_/-]+`' | head -1 | tr -d '`')
BASE_BRANCH=${BASE_BRANCH:-main}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Parse base branch names that contain dots

The base-branch extractor grep -oE '[a-zA-Z0-9_/-]+' excludes . characters, even though dotted names are valid Git branches (for example release/1.2). When project docs specify such a branch, this command returns empty and BASE_BRANCH silently falls back to main, so later git log ${BASE_BRANCH}..HEAD / git diff ${BASE_BRANCH}...HEAD run against the wrong ref (or no ref in repos without main), which can make deep-review miss branch-only changes and incorrectly report there is nothing to review.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant