task-observer: deep-review updates from 2026-05-01#2
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6b27c1900e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| | grep -oE '`[a-zA-Z0-9_/-]+`' | head -1 | tr -d '`') | ||
| BASE_BRANCH=${BASE_BRANCH:-main} |
There was a problem hiding this comment.
Parse base branch names that contain dots
The base-branch extractor grep -oE '[a-zA-Z0-9_/-]+' excludes . characters, even though dotted names are valid Git branches (for example release/1.2). When project docs specify such a branch, this command returns empty and BASE_BRANCH silently falls back to main, so later git log ${BASE_BRANCH}..HEAD / git diff ${BASE_BRANCH}...HEAD run against the wrong ref (or no ref in repos without main), which can make deep-review miss branch-only changes and incorrectly report there is nothing to review.
Useful? React with 👍 / 👎.
Target\nskill:
.agents/skills/deep-review/SKILL.md\n\n## Observations addressed\n- Observation 001 (journology/log.md):/simplifyunavailable leaves no fallback → changed: added explicit fallback: run manual simplify pass inline and note in summary that the dedicated skill was unavailable\n- Observation 005 (journology/log.md): reviewer-override block has no inverse rule for explicitly de-scoped capabilities → changed: added admissibility check (step 3 item 2) before categorization that drops findings targeting project-excluded capabilities; addedPROJECT DE-SCOPING RULESinjection into all Claude Code independent reviewer dispatches\n- Observation 007 (journology/log.md): uncommitted diff recipe omits untracked new files → changed: Step 1 now captures$UNTRACKEDviagit ls-files --others --exclude-standard; Claude Code dispatches generate/tmp/deep-review-untracked.patchand include it in the reviewer prompt\n- Observation 008 (journology/log.md): base branch hard-coded asmainbreaks repos with different integration branches → changed: Step 1 now detects$BASE_BRANCHfrom project docs (PROGRESS.md, AGENTS.md) before falling back tomain; allmain..HEAD/main...HEADreferences updated to use${BASE_BRANCH}Generated by Claude Code