Repository navigation
Conversation
0 = none, 1 = keep paragraph content across unchanged clones, 2 = 1 + skip unused getDesiredWidth on Android. Co-authored-by: Cursor <cursoragent@cursor.com>
…lones Backport of react#59063 (tomekzaw), gated behind discordTextOptimization >= 1. Co-authored-by: Cursor <cursoragent@cursor.com>
Backport of react#59064 (tomekzaw), gated behind discordTextOptimization >= 2. Co-authored-by: Cursor <cursoragent@cursor.com>
kosmydel
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backports two open upstream text perf PRs by tomekzaw behind a new numeric feature flag
discordTextOptimization(default0), so the Discord app can A/B them:1: react/react-native#59063. UnchangedTextsiblings keep their attributed string and measured layouts when Yoga clones them, which avoids per-sibling state updates,setTextand re-layout.2:1+ react/react-native#59064. Skips the unusedLayout.getDesiredWidthpass in AndroidTextLayoutManager.createLayout.With the flag at
0, both code paths behave exactly as before.Note
The Discord app side (libdiscore experiment
2026-10-android-text-optimizationdriving the flag on Android) is in https://github.com/discord/discord/pull/329378.Test steps
com.facebook.react.views.text.*), C++ build.Texts" and compare UI-threadupdateState/setTextcounts between 0 and 1.Made with Cursor