native module refinement

[jeff-hykin]

Native module refinement (rebuild logic and logging) and keyboard interrupt improvement

[greptile-apps]

Greptile Summary

This PR refines the native-module lifecycle with a stop-lock to prevent re-entrant shutdown races, orphan-process prevention via start_new_session=True + PR_SET_PDEATHSIG (Linux), a cli_name_override mapping, an auto_build / BUILD_NATIVE flag for on-demand rebuilds, and improved structured logging throughout. The worker process now ignores SIGINT (SIG_IGN) instead of catching KeyboardInterrupt, cleanly deferring Ctrl-C handling to the coordinator.

Confidence Score: 5/5

Safe to merge; all remaining findings are P2 style/reliability suggestions that do not block correct operation.

Previously flagged P1 issues (TimeoutExpired after SIGKILL, re-entrant stop) are resolved. New findings are P2: a reduced shutdown timeout that may be too short for heavy-teardown processes, missing stderr in the build-failure exception, and a minor find_library edge case. None of these are blocking correctness bugs.

dimos/core/native_module.py — shutdown_timeout reduction and build-error message regression deserve a second look before shipping to users with slow-teardown native processes.

Important Files Changed

Filename	Overview
dimos/core/native_module.py	Major refactor: adds stop-lock for re-entrancy safety, start_new_session+PR_SET_PDEATHSIG for orphan prevention, cli_name_override, auto_build flag, and improved logging; shutdown_timeout silently reduced from 10 s → 2 s (DEFAULT_THREAD_JOIN_TIMEOUT).
dimos/core/coordination/python_worker.py	Worker now ignores SIGINT via SIG_IGN and drops KeyboardInterrupt handlers, delegating interrupt handling to the parent; cleaner shutdown path.
dimos/core/global_config.py	Adds build_native: bool config field (default False) sourced from DEFAULT_BUILD_NATIVE, allowing opt-in forced rebuilds via env var.
dimos/constants.py	Adds DEFAULT_BUILD_NATIVE = False constant.
dimos/core/test_native_module.py	Minor test cleanup: removes the explicit LogFormat.TEXT default (it is still the default) and drops the LogFormat import.

Sequence Diagram

sequenceDiagram
    participant Parent as NativeModule (parent)
    participant Proc as Native Process (child)
    participant WD as Watchdog Thread

    Parent->>Proc: Popen(start_new_session=True, preexec_fn=PR_SET_PDEATHSIG)
    Parent->>WD: Thread(target=_watch_process).start()
    WD->>Proc: proc.wait()

    alt Normal stop()
        Parent->>Parent: _stop_lock: _stopping=True
        Parent->>Proc: send_signal(SIGTERM)
        Proc-->>Parent: exits within shutdown_timeout
        Parent->>WD: watchdog.join(timeout)
        WD-->>Parent: joined
        Parent->>Parent: _stop_lock: _process=None, _watchdog=None
        Parent->>Parent: super().stop()
    else Process crashes
        Proc-->>WD: proc.wait() returns (unexpected exit)
        WD->>Parent: self.stop() [re-entrant, lock prevents double-stop]
    else Parent dies unexpectedly
        Proc->>Proc: SIGTERM via PR_SET_PDEATHSIG
    end

Loading

_{Reviews (3): Last reviewed commit: "-" | Re-trigger Greptile}

[leshy]

some changes