Skip to content

Add GIF logo to GIF thumbnails (resolves #1355) #1366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lilymfarris wants to merge 1 commit into
base: master
Choose a base branch
from
+32 −7
Open

Add GIF logo to GIF thumbnails (resolves #1355) #1366

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions layouts/tweet/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,6 +391,26 @@ body {
cursor: zoom-in
}

.tweet-media-gif-icon {
display: block;
}

.tweet-media-gif-overlay-play {
width: 50px;
top: 50%;
left: 50%;
transform: translate(-50%, -50%);
position: relative;
border-radius: 50%;
background-color: rgba(0, 0, 0, 0.7);
border: 2px solid var(--border);
transition: 0.2s;
}

.tweet:hover .tweet-media-gif-overlay-play {
display: none;
}

.tweet-media-element,
.new-tweet-media-img {
block-size: auto;
Expand Down
19 changes: 12 additions & 7 deletions scripts/tweetConstructor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,10 @@ const svgPlayIcon = `<svg viewBox="0 0 24 24" class="tweet-media-video-overlay-p
</g>
</svg>`;

const svgGifIcon = `<svg viewBox="0 0 24 24" class="tweet-media-gif-overlay-play tweet-media-gif-icon">
<text x="12" y="15" text-anchor="middle" font-size="5" font-weight="bold" fill="white">GIF</text>
</svg>`;

// === Static Nodes to be reused ===

/**
Expand Down Expand Up @@ -701,19 +705,20 @@ async function constructTweet(t, tweetConstructorArgs, options = {}) {
// render media content elements
var extended_media_nodes = null;
if (t.extended_entities && t.extended_entities.media) {

const media = t.extended_entities.media;
// videoOverlay if it's only a single video.
const isSingleVideo =
t.extended_entities.media.length === 1 &&
t.extended_entities.media[0].type === "video"
? true
: false;
const isSingleVideo = media.length === 1 && media[0].type === "video";
const isSingleGif = media.length === 1 && media[0].type === "animated_gif";

var videoOverlay = null;
if (isSingleVideo) {

if (isSingleVideo || isSingleGif) {
videoOverlay = elNew(
"div",
{ class: ["tweet-media-video-overlay", "tweet-button"] },
// XXX: htmlToNodes needs to always be called, else .content will be null/undefined.
[htmlToNodes(svgPlayIcon).content]
[htmlToNodes(isSingleGif ? svgGifIcon : svgPlayIcon).content]
);
}
// Render media nodes
Expand Down