Repository navigation
Fix spotlessCheck failing with 0 lint errors on stale clean files - #3189
Merged
Merged
Conversation
When `spotless-clean` only holds files which already match the source on disk, `getUncleanFiles` skips them, but the check then fell through to the lint branch and failed with "There were 0 lint error(s)" even though there were no lints. Only report lints when there are any.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when
spotless-cleanonly has files that already match whats on disk,getUncleanFilesskips them butSpotlessCheckthen fell into the lint branch and threwThere were 0 lint error(s)with nothing in the lints dir. from what i can tell thats what happens afterclean openApiGenerate spotlessApplyin the issue, so now it only throws when there are actual lints. added a test for it plus a changelog entry. Fixes #2992