Repository navigation
Refactor CI workflow to separate jobs and optimize matrix - #3047
Conversation
6cd5c9b to
b66f86c
Compare
There was a problem hiding this comment.
🟡 Changes recommended
The workflow currently uses a likely-invalid runner label (ubuntu-slim) and the new jobs omit build cache credentials, which can break the final gate and significantly reduce CI cache effectiveness.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR refactors the GitHub Actions CI workflow by splitting the previous combined matrix job into distinct jobs per build/test area, aiming to improve parallelism and make the CI surface easier to reason about.
Changes:
- Split the prior combined build matrix into dedicated jobs:
build-gradle,build-maven,test-npm,test-shfmt, andtest-idea. - Add per-job JUnit reporting to surface test failures directly in PR checks.
- Update
final-statusto depend on the new job set.
File summaries
| File | Description |
|---|---|
| .github/workflows/ci.yml | Splits CI into separate build/test jobs with updated matrices and per-job JUnit reporting, and updates the final required status gate accordingly. |
Review details
Suppressed comments (4)
.github/workflows/ci.yml:74
- This job runs Gradle builds but doesn’t set buildcacheuser/buildcachepass. With CI remote build cache enabled (see settings.gradle), leaving these unset disables cache pushes for trusted builds and can increase CI times.
runs-on: ${{ matrix.os }}
steps:
.github/workflows/ci.yml:114
- This job runs Gradle (testShfmt) but doesn’t set buildcacheuser/buildcachepass. With remote build cache enabled in CI (settings.gradle), this prevents cache pushes on trusted builds and can slow CI.
needs: sanity-check
runs-on: ubuntu-latest
steps:
.github/workflows/ci.yml:94
- This job executes Gradle tasks but doesn’t pass buildcacheuser/buildcachepass, which prevents remote build cache pushes on trusted builds (CI remote cache is configured in settings.gradle). Consider aligning with the sanity-check job so CI remains fast.
needs: sanity-check
runs-on: ubuntu-latest
steps:
.github/workflows/ci.yml:141
- This job runs Gradle (testIdea) but doesn’t set buildcacheuser/buildcachepass. In CI, settings.gradle configures a remote build cache and only enables pushing when these are provided, so omitting them here reduces cache effectiveness and can increase CI time.
needs: sanity-check
runs-on: ubuntu-latest
steps:
- Files reviewed: 1/1 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| runs-on: ${{ matrix.os }} | ||
| steps: |
There was a problem hiding this comment.
Do we really need this for now? But it should only be set on main pushes, see
Lines 34 to 42 in cd8b6e2
There was a problem hiding this comment.
it's okay with me if it gets removed, but I believe the buildcache is working and does gain us a fair amount of speedup.
There was a problem hiding this comment.
Refined a bit.
spotless/.github/workflows/ci.yml
Lines 20 to 23 in 07213de
b66f86c to
07213de
Compare
No description provided.