Use platform-native paths in Windows-target test fixtures - #899
Merged
Merged
Conversation
Windows-target shell-integration and enroll-offer paths join with path.win32 regardless of the CI host, so the fixtures that assert them match on every runner. The peer-link suite uses a named pipe on Windows (with its own dead-pipe reclaim test), skips the Unix-inode corpse tests there, and prepares the Unix socket parent before binding. Split out of #892. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Deploying mouseterm with
|
| Latest commit: |
61ceb50
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e1df00ac.mouseterm.pages.dev |
| Branch Preview URL: | https://windows-target-test-paths.mouseterm.pages.dev |
dormouse-bot
approved these changes
Oct 2, 2026
nedtwigg
requested a deployment
to
hosted-preview
October 2, 2026 05:44 — with 
GitHub Actions
Waiting
GitHub Actions
Waiting
This branch is waiting to be deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #892: these are test-portability fixes, so they get their own PR. Windows-target shell fixtures and the peer-link tests now build paths with `path.win32` / platform-native pipe names on every CI host. The Unix peer-socket test also prepares its parent directory.
Production behaviour is unchanged apart from `enroll-offer.ts` honouring an injected target platform's path flavour.
Validation (macOS): enroll-offer and mirrored-constants 36/36, pty-core 121/121, peer-link 48 passed and 1 skipped (the Windows-only named-pipe case), vscode-ext tsc clean. The Windows-only paths were not exercised locally.
🤖 Generated with Claude Code