Audit mouse, mobile, and theme contracts against code - #895
Merged
Merged
Conversation
Deploying mouseterm with
|
| Latest commit: |
7fb725d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://9b7d4ece.mouseterm.pages.dev |
| Branch Preview URL: | https://spec-cleanup-input-rendering.mouseterm.pages.dev |
dormouse-bot
reviewed
Oct 2, 2026
dormouse-bot
left a comment
Collaborator
There was a problem hiding this comment.
docs/specs/mouse-and-clipboard.md repeats the new pending-banner-action rule; suggestion inline.
nedtwigg
requested a deployment
to
hosted-preview
October 2, 2026 04:50 — with
GitHub Actions
Waiting
nedtwigg
added this pull request to stack #896
October 2, 2026 05:05
dormouse-bot
approved these changes
Oct 2, 2026
…ment The original replaced a 30-line source-text parity test with a 71-line subprocess test that ran the real generator under a string-built preload patching fetch and fs.writeFileSync. If the generator ever wrote through fs/promises, the patch would miss and the test would overwrite the checked-in bundled.json. The dedup it guarded already fails loudly: bundle-themes imports convert.ts directly, so a broken import stops `pnpm bundle-themes`. The original also said the diagonal secondaries are "stacked outward". rootOptionLayout puts them above and below the primary, on its far side. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dormouse-bot
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Audit mouse/clipboard, mobile UI, theme, and shortcut references. Correct selection and copy boundaries, radial placement, paste rules, and disabled native file-drop status. Put single-module mechanics beside their implementation while retaining cross-module invariants and Future designs.
Cancel stale mouse-override confirmation actions when the store transitions. The theme bundle generator imports the same pure converter as browser imports, removing its duplicate inventory and source-text parity test. Correct the Windows xterm-bump fixture and assert actual rejection reasons.
Validation: existing input/theme suites, strict library types, production build, spec/public-doc/xterm gates. Current platform checks and bot review pass. Spec budgets fall by 550 words. Stacked on #894.