Fix CLI target parsing and Tool protocol/save contracts - #893
Merged
Merged
Conversation
Deploying mouseterm with
|
| Latest commit: |
ac48a4b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c53fcbdd.mouseterm.pages.dev |
| Branch Preview URL: | https://spec-cleanup-cli-tools.mouseterm.pages.dev |
nedtwigg
requested a deployment
to
hosted-preview
October 2, 2026 03:31 — with 
GitHub Actions
Waiting
GitHub Actions
Waiting
dormouse-bot
approved these changes
Oct 2, 2026
nedtwigg
added this pull request to stack #896
October 2, 2026 05:05
# Conflicts: # docs/specs/security.md
The original Windows save staged each draft in an owner-only directory created by compiling a C# CreateDirectoryW P/Invoke through PowerShell Add-Type. Every save spawned PowerShell twice and compiled C#, failed outright with no fallback under Constrained Language Mode, and ran in no CI job, all to keep draft bytes private in the rare case of a restrictive document ACL inside a readable directory. Node now writes the draft beside the document, and one [IO.File]::Replace call swaps it in with an original-file backup, which still fixes the EPERM rename and preserves the document's ACL. An unconfirmed replacement still keeps both the draft and the backup. A Windows draft now inherits its directory's ACL until the swap; the spec says so. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dormouse-bot
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Audit the CLI, Tool, and built-in Tool contracts against their producers and consumers. Correct cross-window addressing, protocol bounds, save-channel generations, and folder truncation; let canonical types own syntax and shape.
Fix browser target parsing, reject oversized or terminal-injecting OSC payloads, and prevent a replaced iframe connection from answering an old save. Built-in Windows editor saves stage bytes with Node and preserve destination permissions through native File.Replace. Bound retries for Windows sharing errors in Tool-trust JSON commits.
Validation: existing CLI, Tool protocol, built-in viewer/save, and control-server suites; strict library types and host bundles. Current platform CI and bot review pass. Stacked on #892.