Fix platform-specific standalone build warnings - #889
Merged
Merged
Conversation
Deploying mouseterm with
|
| Latest commit: |
7ca5bcd
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://96bff5ac.mouseterm.pages.dev |
| Branch Preview URL: | https://build-warning.mouseterm.pages.dev |
dormouse-bot
approved these changes
Oct 2, 2026
| restrict: impl Fn(&Path, u32) -> Result<(), String>, | ||
| ) -> Result<(), String> { | ||
| let dir = ensure_parent_with(path, &restrict)?; | ||
| let _dir = ensure_parent_with(path, &restrict)?; |
Collaborator
There was a problem hiding this comment.
Optional: _dir reads as unused, but it's still used on unix at the dir fsync below. Scoping the allow to non-unix keeps the name honest:
Suggested change
| let _dir = ensure_parent_with(path, &restrict)?; | |
| #[cfg_attr(not(unix), allow(unused_variables))] | |
| let dir = ensure_parent_with(path, &restrict)?; |
(and File::open(dir) at the fsync)
nedtwigg
requested a deployment
to
hosted-preview
October 2, 2026 02:21 — with 
GitHub Actions
Waiting
GitHub Actions
Waiting
This branch is waiting to be deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows standalone builds reported an unused directory binding and an unused restart helper. Mark the Unix-only directory binding as intentionally unused elsewhere and compile
QuitMachine::forget_restartonly on macOS or in tests, also removing Linux's unused-method warning. Preserve directory permission checks, Unix syncing, and restart tests, and clarify the standalone spec's macOS termination rule.Validation:
pnpm exec cargo check --release --lib --locked --offlinecompleted without warnings.pnpm exec cargo test --lib --locked --offline: 121 tests passed; existing test-only warnings remain.node scripts/spec-lint.mjsandgit diff --checkpassed.