Unify Workspace confirmations and commit Surface moves synchronously - #888
Merged
Merged
Conversation
The Workspace close, the cross-Window iframe move gate and the Surface move iframe consent shared the strip as three typed-letter slots with their own precedence. They are now one slot: a newer confirmation, or any close, cross-Window move or Surface move starting by gesture or dor, answers the pending one no first. A declined consent releases the Surface move's guard and transfer flags synchronously, so the verb that cancelled it starts at once and the superseded move's cleanup cannot clear a newer move's flags. Move eligibility is one surfaceMoveRefusal shared by the coordinator, the drag targets and the picker; it no longer refuses for an open dialog. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…atch With the cwd probe skipped, building a record never awaits, and a new Workspace's Wall registers inside its flushSync render. So after the last await the coordinator creates the destination, fences both revisions, departs, adopts, finishes both Walls and publishes both records in one synchronous run. session-save splits a synchronous assemblePersistedSession out of buildPersistedSession; the Wall handle's serializeNow replaces the async serializePersistence. The aggregator's write batch becomes publishWorkspaceSessions, which sets several records behind one scheduled write, so even a pagehide write never holds half a move. Rollback can only run before finishSurfaceMove, so it no longer disposes an auto-refill shell, and no record needs republishing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Deploying mouseterm with
|
| Latest commit: |
45bed76
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7b6b3824.mouseterm.pages.dev |
| Branch Preview URL: | https://review-move-followups.mouseterm.pages.dev |
dormouse-bot
approved these changes
Oct 2, 2026
nedtwigg
requested a deployment
to
hosted-preview
October 2, 2026 01:10 — with 
GitHub Actions
Waiting
GitHub Actions
Waiting
This branch is waiting to be deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close and move confirmations now share one slot: starting another close or move cancels the previous question. Surface departure, adoption, and publication of both workspace records run synchronously, without a persistence batch.
Review fixes prevent older asynchronous close/window-probe/editor preparation from replacing newer consent or acting afterward. Saves collected during React’s move commit are fenced as well, preserving a moved exited terminal’s retained cwd. Updated the specs and navigation guide, with regression tests for both races. Fixed a pre-existing date-sensitive Network Settings story fixture exposed by Argos after midnight.
Validation: full
pnpm testandpnpm buildpassed; standalone TypeScript check and Storybook build passed. Innerdogfood verified real terminal moves to existing and new workspaces, superseded iframe consent, and refresh after the displayed confirmation key.