Skip to content

move flag initialisation in smt2_convt#8965

Merged
tautschnig merged 1 commit intodevelopfrom
smt2-flags-init
Apr 22, 2026
Merged

move flag initialisation in smt2_convt#8965
tautschnig merged 1 commit intodevelopfrom
smt2-flags-init

Conversation

@kroening
Copy link
Copy Markdown
Collaborator

This moves the initialisation of the flags used by smt2_convt from the constructor to the member declaration.

This makes it easier to see that they are indeed initialised, and how.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • n/a Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

This moves the initialisation of the flags used by smt2_convt from the
constructor to the member declaration.

This makes it easier to see that they are indeed initialised, and how.
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.49%. Comparing base (0656298) to head (a323678).
⚠️ Report is 5 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #8965   +/-   ##
========================================
  Coverage    80.49%   80.49%           
========================================
  Files         1704     1704           
  Lines       188805   188797    -8     
  Branches        73       73           
========================================
- Hits        151983   151981    -2     
+ Misses       36822    36816    -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tautschnig tautschnig merged commit 1b41bbe into develop Apr 22, 2026
43 of 44 checks passed
@tautschnig tautschnig deleted the smt2-flags-init branch April 22, 2026 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants