Repository navigation
fix(ci): isolate site tests and use bundled snapshot fonts - #3597
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and fix
The Site build fails because the MCP regression test imports Vitest, but the site installs dependencies independently and did not declare it. Add Vitest to the site's dev dependencies and lockfile, expose
yarn test, and run those tests in the Site workflow.The two wrapped-text float snapshots fail on Linux because the PDF.js test helper has no standard-font directory configured. The reproduced Linux diff shows substituted glyphs with unchanged line breaks and pagination. Load PDF.js's bundled standard fonts instead of falling back to fonts on the host. No renderer behavior, snapshot images, or comparison thresholds change.
Validation