Skip to content

fix(ci): isolate site tests and use bundled snapshot fonts - #3597

Merged
diegomura merged 2 commits into
masterfrom
codex/fix-site-and-float-ci
Oct 20, 2026
Merged

diegomura merged 2 commits into
masterfrom
codex/fix-site-and-float-ci

Conversation

@diegomura

Copy link
Copy Markdown
Owner

Problem and fix

The Site build fails because the MCP regression test imports Vitest, but the site installs dependencies independently and did not declare it. Add Vitest to the site's dev dependencies and lockfile, expose yarn test, and run those tests in the Site workflow.

The two wrapped-text float snapshots fail on Linux because the PDF.js test helper has no standard-font directory configured. The reproduced Linux diff shows substituted glyphs with unchanged line breaks and pagination. Load PDF.js's bundled standard fonts instead of falling back to fonts on the host. No renderer behavior, snapshot images, or comparison thresholds change.

Validation

  • Reproduced both float failures in a clean Linux container before the fix.
  • Isolated site install, all 5 MCP tests, and production Next.js build pass without root dependencies.
  • All 115 renderer tests pass on macOS; all 14 float tests also pass on Node 20.
  • Lint and formatting checks pass.
  • Full clean Linux test run passes: 3,666 tests passed, 1 todo, including both previously failing float snapshots.

@vercel

vercel Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
react-pdf Ready Ready Preview Oct 20, 2026 10:48pm UTC

Request Review

@changeset-bot

changeset-bot Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 66e091f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@diegomura
diegomura merged commit f765c95 into master Oct 20, 2026
17 checks passed
@diegomura
diegomura deleted the codex/fix-site-and-float-ci branch October 20, 2026 22:50

This branch was successfully deployed

1 active deployment
Preview — 66e091fd Deployed Oct 20, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant