Repository navigation
Release 0.5.1: Digital Credentials API in the SDK iframe - #32
Merged
Merged
Conversation
Release notes for the iframe's digital-credentials-get permission and the lifecycle fixes that landed after 0.5.0 was published (they were listed under 0.5.0, which did not contain them). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Codex review ( 💡 Code reviewReviewed commit:
The new 0.5.1 entry is dated 2026-10-31, while the preceding 0.5.0 release is dated 2026-11-01, making the later semantic version appear to have been released earlier. Update the new entry to its actual release date, or correct the 0.5.0 date if that existing date is inaccurate. Verdict: APPROVE |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
@didit-protocol/sdk-web0.5.0 on npm does not listdigital-credentials-getin the verification iframe'sallowattribute.A page that embeds the flow with the published SDK (modal or embedded) therefore cannot reach a digital ID wallet: the browser blocks the W3C Digital Credentials API inside the iframe, so the hosted flow cannot offer Google Wallet.
The fix is already on
master(#25), together with lifecycle fixes from #26, but none of it is published.Those lifecycle fixes were also listed under
[0.5.0]in the changelog although 0.5.0 did not contain them.Solution
npm version 0.5.1 --no-git-tag-version).[0.5.1]changelog section thatrelease.ymlturns into the GitHub release notes: the new iframe permission, plus the five fixes moved out of[0.5.0], which goes back to what actually shipped.@didit-protocol/signalsneeds no release: 0.5.1 still depends on^0.1.0, which is published.After merge, the
v0.5.1tag runsrelease.yml, which publishes to npm through trusted publishing.Verification
npm cithennpm run test:build-version:Verified package-derived SDK_VERSION 0.5.1 and simulated 9.8.7.dist/didit-sdk.umd.min.js,didit-sdk.module.jsanddidit-sdk.cjscontaindigital-credentials-get.awkextraction of[0.5.1]fromCHANGELOG.mdreturns the new section.allowends withdigital-credentials-get.🤖 Generated with Claude Code