Repository navigation
DID-9566: [QA-SIGNALS-SDK] Browser monitoring signals and event delivery - #29
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
submitEvent()crashed with an untypedRangeError: Invalid time valuewhen an integrator passed an invalidoccurredAtDate (for examplenew Date("not a date")from a failed parse).buildEventRequestBody()calledtoISOString()before the documented input checks, so bad input escaped the SDK'sDiditEventErrorcontract and broke the caller's sign-in flow instead of reporting a validation problem.Solution
occurredAtinsubmitEvent()and refuse an invalid Date with a typedvalidationerror, matching the existing token and category checks.occurredAttype comment.Verification
npm run typecheck,npm run buildandnpm run test:sizepass; the bundle is 5,107 of 5,120 bytes.