Repository navigation
DID-9564: [QA-WEB-AUTH-REACT] React Authentication provider, hooks and session state - #28
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
QA of the React Authentication adapter found three ways its session state could disagree with the browser's real session:
<DiditAuth>scopes on one page: the scope that completed a returning sign-in showed signed in, while the other stayed signed out, because nothing told it the shared session had been established.TOKEN_REFRESHEDwith no cached session) was treated as a sign-out, so signed-in UI could flash to its guest state.load()rejects left every consumer inloadingforever: neither<SignedIn>nor<SignedOut>rendered, and no error state existed.navigator.languageduring render, so server-rendered English HTML hydrated as another language.Solution
core.ts: page-scoped peers re-read the shared session when one scope restores, signs in or signs out; a stale "no session" read never undoes a session a peer established;TOKEN_REFRESHEDwithout a session keeps the current one.context.tsx: a failed load reads as signed out instead of loading forever, and the browser language is read after mount so SSR and hydration agree.Verification
npm run test:auth(48 auth-react, 103 auth-nextjs), rootnpm test(188),npm run lint,npm run typecheck:auth,npm run build,npm run test:packages.