Repository navigation
DID-9563: [QA-WEB-AUTH-CORE] Browser Authentication SDK core journeys - #27
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The auth core package's browser suite covered the hosted redirect, concurrent tabs, step-ups and bot protection, but not most headless methods, and not cancelled or invalid redirects, passkey cancellation, reload restoration, revoked sessions or credential leakage. Those journeys are release-QA requirements, so a regression in them would ship untested.
Solution
packages/auth/e2e/journeys.spec.mjs, 15 browser journeys driving the built package in the independent fixture app against the recorded runtime API.Verification
npm testinpackages/auth: 101 unit tests pass.npx playwright testinpackages/auth: 87 pass, 8 live tests skipped (Chromium, Firefox and WebKit).npm run typecheckandnpm run buildinpackages/authpass.e2e/live.spec.mjs) could not run here because this checkout has no Didit auth service or mailbox; it remains the check for real passkey registration, passkey protection, email delivery and token rotation against staging.