Skip to content

DID-9446: [QA-REACT-NATIVE] React Native wrapper integration - #66

Merged
botinc-agent[bot] merged 1 commit into
mainfrom
botinc/run-6712e0b8
Oct 30, 2026
Merged

botinc-agent[bot] merged 1 commit into
mainfrom
botinc/run-6712e0b8

Conversation

@botinc-agent

@botinc-agent botinc-agent Bot commented Oct 30, 2026

Copy link
Copy Markdown
Contributor

Problem

The opt-in language selector added in 4.9.0 could never be enabled on iOS. The JavaScript layer and the Android bridge forward showLanguageSelector, and the iOS bridge's Swift configuration type reads it, but the Objective-C++ config dictionary that crosses into Swift never included the key. Native received no selector flag, so the welcome screen stayed as it was even when an integrator set showLanguageSelector: true.

Solution

  • Forward showLanguageSelector in configDictFrom in ios/SdkReactNative.mm, matching the other DiditConfig booleans and the Android parser.
  • Add native-config-forwarding.test.ts, which reads the public VerificationConfig type and both native parsers and fails when a key has no counterpart on either platform.

Verification

  • New test fails on the iOS showLanguageSelector case before the fix and passes after it.
  • yarn lint and yarn typecheck pass.
  • yarn test --maxWorkers=2 passes: 16 suites, 142 tests.
  • Native sample builds for iOS and Android could not run in this Linux sandbox (no Xcode or Android SDK); the repository's iOS/Android CI jobs remain the build check.

@botinc-agent
botinc-agent Bot merged commit 2b1f9aa into main Oct 30, 2026
5 checks passed
@botinc-agent
botinc-agent Bot deleted the botinc/run-6712e0b8 branch October 30, 2026 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant