Repository navigation
DID-9446: [QA-REACT-NATIVE] React Native wrapper integration - #66
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The opt-in language selector added in 4.9.0 could never be enabled on iOS. The JavaScript layer and the Android bridge forward
showLanguageSelector, and the iOS bridge's Swift configuration type reads it, but the Objective-C++ config dictionary that crosses into Swift never included the key. Native received no selector flag, so the welcome screen stayed as it was even when an integrator setshowLanguageSelector: true.Solution
showLanguageSelectorinconfigDictFrominios/SdkReactNative.mm, matching the otherDiditConfigbooleans and the Android parser.native-config-forwarding.test.ts, which reads the publicVerificationConfigtype and both native parsers and fails when a key has no counterpart on either platform.Verification
showLanguageSelectorcase before the fix and passes after it.yarn lintandyarn typecheckpass.yarn test --maxWorkers=2passes: 16 suites, 142 tests.