Repository navigation
DID-9477: [QA-SDK-PHP] PHP server SDK release contract - #19
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
POST /v3/travel-rule/wallet-addresses/import/accepts a JSON object withentries, a bare JSON array of rows, or a CSV upload. When an operation has more than one content type, the generator merged the forms by reading only each schema's top-levelproperties. A rootoneOf/anyOfschema has none, so the JSON branch was silently dropped:TravelRuleWalletAddressesBulkImportParamsexposed onlyfile. The documentedentriesform was missing from the typed surface, so PHPStan (the SDK's selling point) rejected a valid, documented call.Solution
_merge_body_schemasnow flattens a rootoneOf/anyOf: every branch's properties reach the merged request shape, and a field is required only when every branch requires it.entriesfield and its row shape, the row's enum constants, and the object hint the request encoder needs.Verification
python3 -m unittest discover -s codegen/tests: 61 tests pass, including two new ones for a union body that also has a multipart form.python3 codegen/generate.py --check: 1763 generated files up to date;entriesis absent before the fix and present after.