Repository navigation
fix(release): tag releases as v1.0.0 and stop pinning tests to 0.1.0 - #15
Merged
Merged
Conversation
release-please tagged the first release didit-protocol/sdk-php-v1.0.0, because the package name carries the vendor. Composer and Packagist read versions from tags like v1.0.0, and the slash broke the archive step of publish.yml. include-component-in-tag: false makes the tag v1.0.0. The spec sync tests pinned the SDK version to 0.1.0, so the 1.0.0 version bump failed CI. They now read the version from src/Version.php. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Codex review ( 💡 Code reviewReviewed commit: No findings in commit Verdict: APPROVE |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
didit-protocol/sdk-php-v1.0.0because the release-please package name includes the vendor. Packagist only reads version tags likev1.0.0, and the slash broke the archive step ofpublish.yml(run 40835005991:could not open 'sdk-php-didit-protocol/sdk-php-v1.0.0.zip').codegen/tests/test_spec_sync.pypinned the SDK version to0.1.0, so the 1.0.0 version bump failed CI (3 failures in run 40835006038).Solution
release-please-config.json:include-component-in-tag: false, so tags arev1.0.0.src/Version.phpand derive the next minor version.Verification
python3 -m unittest discover -s codegen/tests -p test_spec_sync.py: 13 tests OK.python3 codegen/generate.py --check: 1761 generated files are up to date.🤖 Generated with Claude Code