Repository navigation
fix(release): tag releases as v1.0.0 - #16
Merged
Merged
Conversation
release-please tagged the first release didit-java-v1.0.0 because the package name is set, and the publish job checks the tag against v<version>, so it stopped before uploading to Maven Central. include-component-in-tag: false makes the tag v1.0.0, the format the workflow and the other SDKs use. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Codex review ( 💡 Code reviewReviewed commit: No blocking findings in commit Verdict: APPROVE |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
release-please tagged the first release
didit-java-v1.0.0(the package name goes into the tag by default). The publish job checks the tag againstv<version>(test "v${version}" = "didit-java-v1.0.0"), so run 40877175491 stopped before uploading to Maven Central.Solution
include-component-in-tag: falseinrelease-please-config.json, so tags arev1.0.0, the format the workflow expects and the other SDKs use (same fix as sdk-php#15).Verification
v${version}, which this tag format satisfies.🤖 Generated with Claude Code