Repository navigation
DID-9284: [GO-SYNC] Go SDK: fix the code generator for the new transactions batch-delete operation, merge the 2026-10-29 spec sync and release the missing endpoints - #12
Open
botinc-agent[bot] wants to merge 3 commits into
Conversation
…ctions batch-delete operation, merge the 2026-10-29 spec sync and release the missing endpoints
…ctions batch-delete operation, merge the 2026-10-29 spec sync and release the missing endpoints
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The 2026-10-29 spec sync (PR #8) failed
TestTransactionsBatchDelete: the request sent{}instead oftransaction_uuids, so the nine server operations added upstream never reached the Go SDK. The batch-delete body keeps its fields inside twooneOfvariants, andcollectPropsincodegen/types.goread only$ref,allOfand directproperties. The result was an emptyTransactionsBatchDeleteParams.The same spec also changes two shapes that 1.0.1 code compiles against. Regenerating as-is required a params argument on
RegulatoryReports.Delete(ctx, id)and removed 33 exported Travel Rule network names.Solution
collectPropsalso readsoneOf/anyOfobject variants. A field is required only when every variant requires it.Transactions.BatchDelete,AddressValidation.Validate, fiveTravelRule.Networksand twoTravelRule.WalletProofsmethods, each with a generated test. The fix also fills in fields that 5 AML-monitoring responses lacked.openapi/compatibility.json, read by the generator:Delete(ctx, id)keeps its signature, andDeleteWithParamssendsconfirm_delete.compat_test.gocompiles code that uses every kept name. README and CONTRIBUTING document the rule.Verification
apidifffrommain(1.0.1) to this branch: 0 incompatible changes (37 atc7d222e).mainand this branch, and fails atc7d222ewith the 5 errors the review reported.compatibility.json,compat_test.gofails to compile.go vet(examples too),go run ./codegen -check, staticcheck v0.8.2 and golangci-lint v2.15.0: clean.go test -race:./codegen,TestContract(368 operations) and the regulatory reports, Travel Rule and compatibility tests passed. No other generated file changed in this revision. CI's sync simulation passed locally up to generation and these tests.a5cfac5(run 40941875100): all 12 jobs passed. That covers tests on Go 1.22 to 1.27 (Linux, plus macOS and Windows on 1.27), lint, the generated-code check, 90% core coverage and the secret scan.