Repository navigation
DID-9447: [QA-FLUTTER] Flutter wrapper integration - #29
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When the caller did not set
DiditConfig.languageCode, the wrapper forwarded onlyLocale.languageCode. The native SDKs name Simplified Chinese, Traditional Chinese and Brazilian Portuguese with their own codes, so azh_TWorpt_BRdevice was sent to the genericzh/ptUI. The new test shows the old behavior (zh_TW->zh).Solution
_deviceLanguageCode():Hant/TW/HK/MO->zh-TW,Hans/CN/SG->zh-CN,pt_BR->pt-BR, otherwise the two-letter language. An explicitlanguageCodestill wins.test/wrapper_contract_test.dart, covering all configuration options on both entry points, the success, cancel and failure callbacks, and transaction callback routing.Verification
Expected: 'zh-TW',Actual: 'zh') and passes after the change.flutter analyze(root and the three variants): no issues.flutter test -r expanded: 39 tests pass (26 existing, 13 new).flutter testinexample: passes.