Skip to content

Release Flutter 4.9.1 with matching native SDK pins - #25

Merged
arosasg merged 2 commits into
mainfrom
release/flutter-4.9.1
Oct 6, 2026
Merged

arosasg merged 2 commits into
mainfrom
release/flutter-4.9.1

Conversation

@arosasg

@arosasg arosasg commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

Summary

Releases didit_sdk, didit_sdk_core, didit_sdk_autodetection and didit_sdk_nfc 4.9.1, pinned exactly to native iOS and Android 4.9.1.

  • Root pubspec, podspec, Package.swift and Android Gradle pins bumped; the three variant packages regenerated with tool/generate_variant_packages.sh.
  • Root README dependency snippets (they still said ^4.8.0) and the sdk-ios podspec URLs point at 4.9.1; the example Podfile and both example lockfiles resolve the released 4.9.1 binaries.
  • Release notes in release-notes/4.9.1.md (the release workflow reads them for the GitHub Release).

What 4.9.1 ships

  • Both platforms: the document and proof of address country pickers open on the IP-detected country instead of the first country in the list (iOS: document country picker opens on Afghanistan instead of the geolocated country #23).
  • Android: questionnaire header and fields follow the SDK language.
  • Android: NFC passport scanning no longer crashes with a missing org.jmrtd.BACKey class in didit_sdk.
  • Both platforms: improved Russian and Kyrgyz copy.

Verification

  • flutter analyze clean; flutter test 18/18 pass.
  • pod install in example/ios resolves DiditSDK/All 4.9.1 from the released sdk-ios 4.9.1 podspec.
  • Native releases: sdk-ios 4.9.1 is published (all consumer checks green); sdk-android 4.9.1 is in Release Android SDK 4.9.1 sdk-android#16 - the Android example build goes green once that merges.

Tag v4.9.1 after merge; the release workflow publishes all four packages to pub.dev.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@arosasg

arosasg commented Oct 6, 2026

Copy link
Copy Markdown
Contributor Author

Codex review (codex CLI, account codex-5, model gpt-5.6-sol)


💡 Code review

Reviewed commit: 8c6e103

P1 Badge Add 4.9.1 entries to every package changelog

pubspec.yaml:L3 - view

When these four packages are published as 4.9.1, their bundled CHANGELOG.md files still begin at 4.9.0, so pub.dev displays stale release information and package validation may warn that the current version is undocumented. Run tool/generate_variant_packages.sh, which is designed to propagate release-notes/4.9.1.md into the root and variant changelogs, and commit all four generated entries.

Verdict: REQUEST CHANGES

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@arosasg

arosasg commented Oct 6, 2026

Copy link
Copy Markdown
Contributor Author

Round-1 fix pushed in ae3dc40: P1 changelog entries - valid. I had run tool/generate_variant_packages.sh before writing release-notes/4.9.1.md; re-running it generated the 4.9.1 entry in the root and all three variant CHANGELOG.md files (no other file changed), which also keeps the CI variant-drift gate clean.

@arosasg

arosasg commented Oct 6, 2026

Copy link
Copy Markdown
Contributor Author

Codex review (codex CLI, account codex-5, model gpt-5.6-sol)


💡 Code review

Reviewed commit: ae3dc40

No findings for commit ae3dc40.

Verdict: APPROVE

@arosasg
arosasg merged commit 3baabc2 into main Oct 6, 2026
4 checks passed
@arosasg
arosasg deleted the release/flutter-4.9.1 branch October 6, 2026 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant