Repository navigation
Release Flutter 4.8.0 with matching native SDK pins - #21
Conversation
Move didit_sdk and its three generated variants to 4.8.0 and pin native DiditSDK 4.8.0 on iOS (podspec dependency, Package.swift, example Podfile, README) and me.didit 4.8.0 on Android. Variants regenerated with tool/generate_variant_packages.sh. Release notes and changelog describe what the native 4.8.0 adds. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Co-authored-by: arosasg <46827020+arosasg@users.noreply.github.com>
|
🛰️ BotInc review loop - review, wave 1/5 by Code Reviewer · DID-3561 💡 Code reviewReviewed commit: Flutter PR #21: no blocking code defects found in All four packages passed a local consistency check covering wrapper versions, Android dependencies, CocoaPods dependencies, SwiftPM requirements, and changelogs. CI passed analysis/tests and variant regeneration. Flutter is unavailable locally, so I did not independently execute its test suite. Both native example builds failed in CI. This code approval preserves the PR's explicit hold: publish the native 4.8.0 dependencies, complete the documented iOS example lockfile refresh, and obtain successful native builds before merging or tagging. The GitHub connector could not resolve the iOS 4.8.0 tag or Android 4.8.0 artifact; web fallback also could not retrieve them. I could not retrieve CI failure logs, so I am not attributing every build failure to those missing dependencies. Verdict: APPROVE Reviewed commit: React Native PR #54: no blocking code defects found in Independently ran all five test suites: 37 tests passed, including native SDK pin coverage and Expo Podfile generation. CocoaPods, SwiftPM, Gradle, and documented pins agree on 4.8.0. CI passed lint/typecheck, tests, and the JavaScript library build. Both native example builds failed in CI; I did not run native builds locally. The same native dependency availability limitation applies. This code approval preserves the PR's explicit hold on merging and tagging until native 4.8.0 is published; successful native build checks remain required. Verdict: APPROVE |
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Co-authored-by: arosasg <46827020+arosasg@users.noreply.github.com>
|
🛰️ BotInc review loop - review, wave 4/5 by Code Reviewer · DID-3561 💡 Code reviewReviewed commit: No actionable defects found in the 28-file diff at Local checks passed for package/native version consistency, copied variant sources, example lockfile versions, the Podfile checksum, shell syntax, and diff whitespace. Confirmed the Android 4.8.0 artifacts exist for all four variants and the published iOS assets match the Swift package checksums. All four current-head CI checks passed: analysis/tests, variant regeneration, Android example build, and iOS example build. Flutter tests and native builds were not rerun locally because the required toolchains are absent from this task environment. No application UI source changes are included in this diff. Verdict: APPROVE |
Release Flutter 4.8.0 pinned to native SDKs 4.8.0 on both platforms.
pubspec.yamland all threepackages/*/pubspec.yaml: 4.8.0 (variants regenerated withtool/generate_variant_packages.sh).ios/didit_sdk.podspecdependency,ios/didit_sdk/Package.swiftexact: "4.8.0", the example Podfile and README podspec URLs, and the generated variant podspecs and manifests.diditSdkAndroidVersion = "4.8.0"in the root and generated variantbuild.gradle.kts.release-notes/4.8.0.mdplus a matching## 4.8.0section in the root and variant changelogs, so pub.dev shows what changed.Local checks on this head:
flutter analyze(no issues) andflutter test(16 tests) on the root package pass.Merge order: this PR merges and is tagged
v4.8.0only aftersdk-ios4.8.0 andsdk-androidv4.8.0 are published, since the pins resolve against those releases.example/ios/Podfile.lockis regenerated against the published iOS podspec in a follow-up commit on this branch once that release exists, the same way 4.7.6 was done. Until then the iOS example CI job fails by design.🤖 Generated with Claude Code