Repository navigation
DID-9479: [QA-SDK-DOTNET] .NET server SDK release contract - #15
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The repository's release contract no longer matched what it ships.
AGENTS.mdandCLAUDE.mdstill said 1.0.0, although 1.0.1 was released on 2026-10-29. The README's versioning section still described the pre-1.0 rule ("until 1.0.0, breaking changes bump the minor version") on a 1.x package. Therelease-please.ymlheader claimed a person publishes a draft release after approval, contradicting the automatic flow inCONTRIBUTING.mdand DESIGN.md section 13: merging the release pull request is the approval, and release-please then tags, releases and starts the NuGet publish.Solution
AGENTS.mdandCLAUDE.mdto 1.0.1.release-please.ymlheader comment to describe the shipped automatic flow; no workflow logic changed.No generated code, public API or package contents changed.
Verification
dotnet build Didit.sln -c Release: 0 warnings, 0 errors.dotnet teston net8.0, net9.0 and net10.0: 897 passed on each.python3 codegen/generate.py --check: 1,973 generated files current; 26 codegen tests pass.dotnet format --verify-no-changesis clean; both NuGet packages pack./me401 and a PKCE/loginredirect against a local issuer stub.Live session create/retrieve on staging was not run: this checkout has no sandbox API key. Its smoke test covers that path when
DIDIT_SANDBOX_API_KEYis set.