Skip to content

docs(release): releases publish straight from the repository - #12

Merged
arosasg merged 3 commits into
mainfrom
docs/releases-publish-from-repo
Oct 29, 2026
Merged

docs(release): releases publish straight from the repository#12
arosasg merged 3 commits into
mainfrom
docs/releases-publish-from-repo

Conversation

@arosasg

@arosasg arosasg commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

Problem

AGENTS.md, CLAUDE.md and docs/DESIGN.md section 13 still said nothing may be tagged or published before 2026-11-01 without Alex's explicit approval. Alex approved 1.0.0 on 2026-10-29 (now published) and asked that every release publish straight from the repository.

Solution

  • The agent rule now says merging the release-please pull request is the release approval; nobody tags or publishes by hand outside that flow, and no registry token is stored where trusted publishing works.
  • docs/DESIGN.md section 13 records the 1.0.0 release, the publish path per registry and the workflow_dispatch hand-off; the file stays byte-identical in all seven SDK repositories (sha1 9aec8cc2).

Verification

  • shasum docs/DESIGN.md is identical in sdk-python, sdk-node, sdk-go, sdk-java, sdk-php, sdk-ruby and sdk-dotnet.
  • Documentation only; no workflow or code changes.

🤖 Generated with Claude Code

@arosasg @claude
docs(release): releases publish straight from the repository
fe8bd52 
Alex approved the 1.0.0 release on 2026-10-29 and asked that every release
publish straight from the repository. The pre-launch rule (no tag or publish
before 2026-11-01 without his approval) is replaced: merging the release-please
pull request is the release approval. docs/DESIGN.md section 13 records the
same, identically in all seven SDK repositories.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@arosasg

arosasg commented Oct 29, 2026

Copy link
Copy Markdown
Contributor Author

Codex review (codex CLI, account codex-7, model gpt-5.6-sol)

💡 Code review

Reviewed commit: fe8bd52

P1 Badge Automate publishing after the release-please merge

docs/DESIGN.md:L252-L253 - view

When a release-please pull request is merged, the current workflow only creates a draft GitHub release, while .github/workflows/release.yml runs exclusively on release: published; therefore no NuGet publication occurs until someone manually publishes the draft, contrary to the newly documented straight-through release process. Update the workflows so release-please dispatches publication for the new tag (as described here), or retain the manual-publishing instructions instead.

Verdict: REQUEST CHANGES

@arosasg @claude
docs(release): drop the pre-launch release policy everywhere
4e223f8 
The SDK is released (1.0.0 on 2026-10-29) and merging the release pull request
is the release approval, so the leftover pre-launch text is replaced: the
README banners, the agent status line, the CONTRIBUTING release sections and
the workflow comments no longer describe a private, unreleased repository or a
reviewer gate on the publish environments (which have no required reviewers).
docs/DESIGN.md section 2.1 records the completed didit-sdk PyPI transfer and
the terms agreed with Agustin Saiz, identically in all seven repositories.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@arosasg

arosasg commented Oct 29, 2026

Copy link
Copy Markdown
Contributor Author

Codex review (codex CLI, account codex-7, model gpt-5.6-sol)

💡 Code review

Reviewed commit: 4e223f8

P1 Badge Use a token that can trigger the release workflow

release-please-config.json:L8 - view

When the release PR is merged, draft: false makes release-please publish the GitHub release using the workflow's default GITHUB_TOKEN; GitHub suppresses workflow runs caused by events created with that token, so the release: published trigger in release.yml will not run and no NuGet packages will be published. Configure release-please with a GitHub App/PAT token that can trigger workflows, or move publication into the release-please workflow via an explicit reusable-workflow/job dependency.

Verdict: REQUEST CHANGES

@arosasg @claude
Merge main (auto-publish hand-off, #11) into docs/releases-publish-fr…
2facae1 
…om-repo

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@arosasg

arosasg commented Oct 29, 2026

Copy link
Copy Markdown
Contributor Author

Codex review (codex CLI, account codex-7, model gpt-5.6-sol)

💡 Code review

Reviewed commit: 2facae1

No blocking findings in commit 2facae1.

Verdict: APPROVE

@arosasg
arosasg merged commit 9615f4a into main Oct 29, 2026
11 checks passed
@arosasg
arosasg deleted the docs/releases-publish-from-repo branch October 29, 2026 13:27
@github-actions github-actions Bot mentioned this pull request Oct 29, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@arosasg