feat: mask raster for features hidden by table filters - #664
Open
BRaimbault wants to merge 5 commits into
Open
Conversation
Prefer toHaveLength() over a generic length assertion, for better failure reporting.
setVisibleIds() (base Layer class) applies an "only show these ids" filter to every registered GL layer, including EarthEngine's new mask layer added in the previous commit. Since the mask's own data is deliberately the complement (the *hidden* ids), that filter matched none of its features and silently zeroed it out - so selectionFilter/ Combined's combinedVisibleIds (which go through setVisibleIds) never visibly masked the raster, even though dataFilters (which goes through filter() instead) did. Layer.addLayer() now accepts an excludeFromVisibleIdsFilter option, used to exempt the mask layer from that blanket filter.
|
BRaimbault
marked this pull request as ready for review
July 29, 2026 13:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.