chore: separate filtering section and context provider - #348
Open
HendrikThePendric wants to merge 1 commit into
Open
chore: separate filtering section and context provider#348HendrikThePendric wants to merge 1 commit into
HendrikThePendric wants to merge 1 commit into
Conversation
Contributor
|
🚀 Deployed on https://pr-348.event-visualizer.netlify.dhis2.org |
|
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of trying to explain all of this in a PR review comment I thought it'd be more efficient to just do a PR against #340, especially because I wasn't sure if my suggestion would result in clean code. I think it has done.
PROS:
CON:
setConditionandstoreConditions, which were internal to theFilteringSectionsection before.I think the pros outweigh the con, since these two new methods are clearly part of a "conditions management domain". Plus I think this also addresses doubt nr. 1 you expressed in the PR description.