[aterga]

Summary

• Station: removing a user group now also removes it from the users that are still members of it, including inactive users, so no user record keeps referencing a group that no longer exists.
• Station: on upgrade, user records drop the ids of user groups that no longer exist. This cleans up groups that were removed before this change. It runs right after the caches are built in upgrade_canister, since the repositories read from the cache.
• Wallet: the remove confirmation on the User Groups page, and remove user group requests that haven't executed yet, list the users that are still members: "Removing this group will affect users A, B who are still members of it." It lists up to 10 names plus a count of the rest, and falls back to a generic message if the members can't be loaded.

Testing

• Station: new unit tests for removing a group with active and inactive members, and for the upgrade cleanup. All 411 station unit tests pass; cargo fmt, clippy and the wasm build are clean.
• Wallet: new spec for the warning (one member, several members, more than 10 members, no members, members can't be loaded). The full wallet suite passes; prettier, eslint and vue-tsc are clean.

The French and Portuguese strings would benefit from a native speaker's review.

---

Generated by Claude Code

[Copilot]

🟡 Changes recommended

Membership warnings can disappear during loading or understate the impact when permissions hide affected users.

2 open issues

• Keep Confirm disabled while member lookup is pending · New
• Avoid presenting partially visible users as full membership · New

What changed in this PR

This PR keeps station user memberships consistent when groups are deleted and adds wallet warnings about affected members.

Changes:

• Remove deleted groups from active and inactive users, and clean up stale memberships during upgrades.
• Show localized membership warnings in removal confirmations and pending removal requests.
• Add station cleanup tests and wallet warning tests.

File	Description
core/​station/​impl/​src/​services/​user_group.rs	Remove memberships on group deletion and test cleanup.
core/​station/​impl/​src/​services/​system.rs	Clean up missing group references after upgrade cache initialization.
apps/​wallet/​src/​pages/​UserGroupsPage.vue	Add membership warnings to removal confirmations.
apps/​wallet/​src/​locales/​pt.locale.ts	Add Portuguese warning messages.
apps/​wallet/​src/​locales/​fr.locale.ts	Add French warning messages.
apps/​wallet/​src/​locales/​en.locale.ts	Add English warning messages.
apps/​wallet/​src/​components/​users/​UserGroupMembersWarning.vue	Fetch and display affected members with a fallback warning.
apps/​wallet/​src/​components/​users/​UserGroupMembersWarning.spec.ts	Test warning text, counts, empty results, and lookup failures.
apps/​wallet/​src/​components/​requests/​operations/​RemoveUserGroupOperation.vue	Show warnings for removal requests awaiting execution.

_{Review effort: Balanced}

[zeropath-ai]

✅ No security or compliance issues detected. Reviewed everything up to 9a01a9e.

Security Overview

• 🔎 Scanned files: 9 changed file(s)
• 🔗 Scan Link: https://zeropath.com/app/repositories/5243341a-e7d7-47de-848a-f52264761c93?scanId=b28d10d6-2f39-4f1d-932e-2047ff54c770&codeScanTypes=PrScan&tab=issues&detectionTypes=traditional,businessLogic,customRule,IAC,SECRETS,CICD,EOL,uncategorized

Detected Code Changes

Change Type

Relevant files

Enhancement

► apps/wallet/src/components/requests/operations/RemoveUserGroupOperation.vue     Modify template to show UserGroupMembersWarning when not loading and add warning component; wrap existing component with additional div and conditionals ► apps/wallet/src/components/users/UserGroupMembersWarning.vue     Add new warning component to display members affected by group removal ► apps/wallet/src/pages/UserGroupsPage.vue     Include UserGroupMembersWarning inside confirmation dialog for removal action