[aterga]

Summary

Stage 1 of the local-deployment design (the design docs merged in #148): extract imcp2-core, the transport/OAuth-agnostic component crate both server binaries build on, leaving imcp2 as the hosted composition (the OAuth 2.1 authorization server, the streamable-HTTP transport, the axum routers, metrics, and the PocketIC e2e harness) that depends on core and re-exports its public items. No behavior change to the imcp2 binary.

Related issues

Implements Implementation Stages → Stage 1 of the design docs merged in #148.

Changes

• Workspace + new crate. imcp2-core carries identities, calls, discover, management, skills, tools (the whole #[tool_router] surface stays co-located with IcTools), the compiled-in static/ references, and the connect assets. Shared version pins move to [workspace.dependencies].
• New iiconnect module — the II connect-handshake primitives lifted out of auth.rs (the /mcp link builder, the pinned callback page rendered to plain html+csp values, the delegation-chain parser + 64 KB bound, the #4091 allow-list path), re-parameterised on plain values. auth.rs keeps thin axum wrappers with identical routes, headers, and bytes.
• Session seam. IcTools::new takes a SessionSource: Bearer resolves the session per request from the AuthedSession extension (now a core type, read via http::request::Parts so core does not depend on axum); Singleton pins one login-established session for a single-user binary. All 13 session lookups go through current_session_id.
• imcp2 re-exports core's public items (Agent, IiInstance, SessionGauges, ic_agent, IC_URL), so embedders' imcp2::… imports keep compiling. rmcp's unused auth feature is dropped.
• Infra: Dockerfile/build.sh copy crates/; CI builds/tests --workspace; the publish workflow checks both versions against the tag and publishes imcp2-core before imcp2 (core's first release is manual, like imcp2's 0.1.0 was, since a trusted publisher can only be configured on an existing crate).

Testing

• cargo build --locked --workspace --all-targets
• cargo test --locked --workspace --all-targets — 206 passed, 0 failed (hosted: 52 lib + 10 bin + 9 router-contract, all pre-existing and unchanged; core: 135 — the moved suites plus new iiconnect tests)
• cargo check --features e2e --all-targets (PocketIC harness still compiles)
• cargo publish --locked --dry-run -p imcp2-core and cargo package --locked --no-verify -p imcp2 rehearse cleanly; the imcp2 .crate contains no crates//static/ leak
• Exit criterion: imcp2-core's dependency graph contains no axum, no direct tower-http, no prometheus, no OAuth code (cargo tree; tower-http 0.6 appears only transitively inside reqwest/rmcp, exactly as before the split)
• rustfmt/clippy: no new warnings introduced (the tree's pre-existing rustfmt drift and 6 pre-existing clippy nits in moved code are left untouched to keep the move reviewable)

Checklist

• I have read the Contributing guidelines.
• Docs updated (the design docs merged in Design docs: IMCP2 local deployment (minimal stdio binary, no OAuth) #148).
• No secrets, credentials, or internal-only information are included.

---

🤖 Generated with Claude Code

https://claude.ai/code/session_01AqNkpMQiQHzYxC2djTfvBK

[Copilot]

Pull request overview

This PR adds a scoping/design document for a separate “run-it-yourself” local MCP server binary that communicates over stdio, targets mainnet IC plus production Internet Identity, and removes the hosted OAuth 2.1 authorization-server layer while retaining an II browser-based delegation handshake.

Changes:

• Add a draft scoping document defining the local-deployment model (stdio transport, no OAuth) and its security assumptions.
• Propose a crate/binary layout (imcp2 core + imcp2-local) and a feature-gated hosted surface to keep the existing deployed imcp2 binary name unchanged.
• Document verified dependency-stripping opportunities and a minimal tool/session seam for a singleton local session.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 13 out of 24 changed files in this pull request and generated no new comments.

Suppressed comments (2)

crates/imcp2-core/src/tools.rs:1526

• Singleton(String) is immutable and always populated, so the planned local server cannot construct IcTools before its lazy login or replace the session after expiry/revocation. The merged design requires a shared Option<String> slot that the login wrapper can fill and replace (docs/scoping-local-deployment.md:437-457). Model Singleton around a cloneable mutable session handle (and expose its read/write API) now; otherwise Stage 2 must break this newly published seam or restart the MCP server for every reauthentication.
  crates/imcp2-core/src/tools.rs:85
• The new session seam is not exercised by the moved tool tests. The existing e2e check only proves a valid token passes require_token; it never invokes a session-dependent tool, so a broken http::request::Parts/AuthedSession lookup would make all 13 authenticated tools report “needs an authenticated session” while the suite still passes. Add coverage for both the hosted Bearer extension path and the local singleton slot (including replacement after re-login).