Repository navigation
ci(health): pin the Internet Identity the production probe checks - #197
Merged
Merged
Conversation
The scheduled Production health run has been red on every tick for weeks, reporting "Linked Internet Identity instance" and "Internet Identity health" as failed while every MCP and OAuth check passed. Left unpinned, the status CLI learns which II to probe from the list the server advertises at /version. Production's fronting edge forwards only the MCP and OAuth paths and answers /version with a redirect to the landing site, so the probe sees no advertised II, marks the instance check failed, and the II health check has nothing to assess. The hosted production dashboard already sidesteps this: deploy.sh pins it to id.ai for exactly this reason. The off-host probe never received the same pin. Set II_ORIGIN in the job environment and pass it as --ii, mirroring how MCP_ORIGIN is supplied. Verified locally against production: unpinned, the CLI exits 1 with overall "fail" and an empty II list; pinned, it exits 0 with overall "pass" and reports the II as explicitly configured. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TGhwpdTbUqQbR5AiiN8Ljw
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The pin matches existing deployment configuration and the CLI’s validated configuration path.
Review effort: Balanced
Findings: None
What changed in this PR
Pins the production health probe to the correct Internet Identity origin, preventing false failures caused by /version redirects.
Changes:
- Adds
II_ORIGIN=https://id.ai. - Passes the origin through
--ii.
| File | Description |
|---|---|
.github/workflows/health.yml |
Configures the production II health target. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
sea-snake
approved these changes
Sep 22, 2026
This was referenced Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The scheduled Production health workflow has been red on every tick for weeks (every scheduled run reachable through the API, back to at least 2026-09-09, and all of today's across three different
maincommits). Each run reports the same two checks failed — "Linked Internet Identity instance" and "Internet Identity health" — while every MCP and OAuth check passes. Production is healthy; the probe cannot tell which II to look at.Left unpinned, the status CLI learns the II to probe from the
instances[]list the server advertises at/version. Production's fronting edge forwards only the MCP and OAuth paths and answers/versionwith a 308 to the landing site, so the probe sees no advertised II, marks the instance check failed, and the II health check then has nothing to assess.monitoring/mcp-status/checks.jsalready documents this exact case and the remedy ("Pin one with--ii/II_ORIGIN, as the deployed production target does"), anddeploy/native/deploy.shpins the hosted production dashboard tohttps://id.aifor the same reason. The off-host probe inhealth.ymlnever received that pin.This sets
II_ORIGINin the job environment, with a comment recording why, and passes it as--ii, mirroring howMCP_ORIGINis supplied. Side effect worth knowing: with the run red on every tick, the Slack alert has been firing continuously, so a real outage would have been indistinguishable from the noise. After this merges, the first cron tick should go green and the alert becomes meaningful again.Related issues
Follows #194 (which touched this file only to point the Slack alert at the public status page). The
/versionredirect it works around is the gateway front described in #165.Changes
.github/workflows/health.yml: addII_ORIGIN: https://id.aito theprobejob env with a comment explaining the pin; pass--ii "$II_ORIGIN"to the CLI alongside--mcp "$MCP_ORIGIN".Testing
overall: "fail",iiOrigins: [], detail "the server advertises no II instances at /version …"II_ORIGIN=https://id.ai(env, as the job now sets it) and separately via--ii https://id.ai: exit 0,overall: "pass",iiOrigins: ["https://id.ai"], source "explicitly configured"II_ORIGINis read bymonitoring/mcp-status/config.js(resolveConfig) and passed through the same allow-list check as--ii;id.aiis in the default allow-list, so noMCP_STATUS_ALLOWED_HOSTSchange is needed.github/scripts/scan-internal-identifiers.sh origin/main...HEADcleancargo build --locked --all-targets— n/a, workflow-only changecargo test --locked --all-targets— n/acargo fmt --all/cargo clippy --all-targets— n/anpm test --prefix monitoring/mcp-status— n/a, dashboard code unchangedThe workflow runs only on
main(schedule / manual dispatch), so it cannot be exercised from this PR; aworkflow_dispatchrun after merge, or simply the next 15-minute tick, is the confirmation.Checklist
🤖 Generated with Claude Code
https://claude.ai/code/session_01TGhwpdTbUqQbR5AiiN8Ljw
Generated by Claude Code