Repository navigation
Conversation
A post-merge audit checked both directory docs against the code at main (0a32373) and against live production. Fixes, all doc-only: - Production gap restated with today's facts: /version reports bbf0844 (v0.1.1), which predates the whole compliance chain (#153-#158) and still serves the old 26-tool surface — a release from current main must be deployed before either submission, since the attestations describe main. - The privacy policy, /support, and /terms are LIVE on production (verified HTTP 200), so the "pending the production release" rows and checklist items now say what actually remains: portal entry, plus the next release refreshing the live text to the current draft. - The mcp-review checklist row contradicted blocker 2's resolved-in-code body and wrongly claimed the first-party-API question was asked on 2026-07-31; it now matches the body. - The listing description claimed "identify what a canister is" — a capability of the unserved dashboard-lookup tool; it now leads with the served Candid fetch. - Stale figures and paths: longest served tool name is 23 chars (get_canister_oql_schema), not 30; the dfinity-logo.svg link and the README's connect.css / static/ paths now point into crates/imcp2-core/ where the files live; "ships with this PR" phrasing updated now that the PR is merged and deployed; the stale cycles-funding justification sentence is dropped (no funding tools exist). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LvwAVXfx5kLNc4SqKXkavk
There was a problem hiding this comment.
Pull request overview
Refreshes submission documentation to match production state and current repository structure.
Changes:
- Updates production readiness and deployment blockers.
- Corrects tool counts, descriptions, and asset paths.
- Removes stale release and financial-tool wording.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
README.md |
Corrects embedded asset paths. |
docs/openai-directory-submission.md |
Refreshes production URLs and checklist. |
docs/anthropic-directory-submission.md |
Updates production gap, listing copy, and checklist. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Review findings on #161: the tool-name-length row now gives both values (23 on main, the build to submit; 30 on the live pre-release build), and the OpenAI checklist gains an explicit item requiring production to run a release cut from current main, verified via /version immediately before submitting — the deploy workflow also accepts older tags/SHAs for rollbacks, so a deployed challenge token alone does not prove the compliant build is live. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LvwAVXfx5kLNc4SqKXkavk
Review finding on #161: the table header claimed live verification for every row, but the tool-surface rows (11 tools, one write, name lengths, schemas) describe main, not the pre-release build production currently runs. The header now says which rows were verified live (transport/auth, 2026-07-31) and that the tool-surface rows describe main pending the release, with a pointer to re-verify after deploying. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LvwAVXfx5kLNc4SqKXkavk
sea-snake
approved these changes
Aug 28, 2026
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
Suppressed comments (1)
Previously missed (1) — in code that hasn't changed since the last review.
docs/anthropic-directory-submission.md:363
- This updated checklist now says the page is live, but the portal field draft at lines 279–282 still instructs the submitter to enter this URL only once the page is live. Update that field draft too so the same document does not present the verified production state as still pending.
- [ ] Privacy policy entered in the portal — the page is already live at `https://mcp.internetcomputer.org/privacy-policy` (verified 2026-08-27); the next `release-*` refreshes its text to the current draft (blocker 1)
aterga
added a commit
that referenced
this pull request
Aug 28, 2026
Per the review rule applied across #158/#161 (describe the current version, not future work): the README's Roadmap section — three unchecked forward-looking items plus a checked history that the feature sections already document — is removed, along with the stale status sentence claiming the live round-trip waits on an II deployment (the II-side connect flow is live). The Anthropic submission doc's parenthetical citing "an open roadmap item in the README" goes with it; its present-tense honesty statement (no per-call confirmation server-side today) stays. Claude-Session: https://claude.ai/code/session_01LvwAVXfx5kLNc4SqKXkavk Co-authored-by: Claude <noreply@anthropic.com>
6 of 7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A post-#158 ship-readiness audit checked both directory docs against the code at
main(0a32373) and against live production. This PR fixes what the audit found stale — all doc-only, no behavior change.Verified against production (2026-08-27)
GET https://mcp.internetcomputer.org/version→bbf0844(v0.1.1, tagrelease-2026-08-18-0.1.1). That build predates the whole compliance chain (Make icp_top_up_canister instructions-only: never execute funding #153, Refuse ledger transfer/approval methods in canister_update_call #154, Remove financial framing; state the server is not for financial operations #155, Split IcTools into IcCanisterTools and IcProtocolTools #157, Serve only the app/canister tools #158) and still serves the old 26-tool surface, funding/management tools included. The production-gap blocker in the Anthropic doc now states this plainly (it previously cited48f1ed6and PRs auth: reject redirect URIs with a query or fragment (MCP05) #98–calls: bound type-less reply decode/render against deep nesting (CWE-674) #108): arelease-*from currentmainmust be deployed before either submission, because every attestation describesmain.GET /privacy-policy,/support,/terms→ all HTTP 200. The "pending the production release" rows and checklist items were stale; they now say what actually remains — portal entry, plus the next release refreshing the live text to the current draft (which carries the restored identifier-linkability wording from Serve only the app/canister tools #158).Doc corrections
get_canister_oql_schema), not 30; thedfinity-logo.svglink and the README'sconnect.css/static/mentions now point intocrates/imcp2-core/where those files live; "ships with this PR" phrasing updated now that it's merged and deployed; the stale "cycles funding is metered compute credit" justification is dropped (no funding tools exist).Verification
future version/anticipatephrasing introduced anywhere (grep-verified).🤖 Generated with Claude Code
https://claude.ai/code/session_01LvwAVXfx5kLNc4SqKXkavk
Generated by Claude Code