Repository navigation
Stage 3: end-user setup, PocketIC login e2e, and the dist release pipeline #152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
aterga
merged 32 commits into
main
from
claude/secondary-mcp-local-deploy-jpof9i-stage3
Aug 27, 2026
Merged
Changes from all commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
490983f
Stage 2: imcp2-local, the stdio binary with built-in II browser login
claude f2128b4
Address review: structured login-tool outputs, status precedence, sta…
claude a8e3798
Stage 3: end-user setup, PocketIC login e2e, and the dist release pip…
claude ee450b7
Merge remote-tracking branch 'origin/main' into claude/secondary-mcp-…
claude df04711
Merge branch 'claude/secondary-mcp-local-deploy-jpof9i-stage2' into c…
claude 1b410be
Address review: serialize registrations instead of guarding the commit
claude f2be5b9
Merge branch 'claude/secondary-mcp-local-deploy-jpof9i-stage2' into c…
claude a5064b1
Address review: Host-validate the login listener (anti-DNS-rebinding)
claude a621136
Merge branch 'claude/secondary-mcp-local-deploy-jpof9i-stage2' into c…
claude f50ad08
Address review: readable variable names in the callback page script
claude 6f669a8
Merge branch 'claude/secondary-mcp-local-deploy-jpof9i-stage2' into c…
claude 1f8c1b7
Address review: authentication moves out of core behind a SessionReso…
claude b4d6378
Merge branch 'claude/secondary-mcp-local-deploy-jpof9i-stage2' into c…
claude d461a01
Adapt the e2e to SessionSlot's new home in the login module
claude 87d56bd
Address review: split the login module, name the contact const, detac…
claude f80948b
Refine the design's tool/session seam: authentication injected, core …
claude f62978b
Merge branch 'claude/secondary-mcp-local-deploy-jpof9i-stage2' into c…
claude 84f7a27
Address review: session reaper + the PocketIC login e2e moves into th…
claude b43b831
Merge branch 'claude/secondary-mcp-local-deploy-jpof9i-stage2' into c…
claude bda8493
Repair the previous merge: dedupe the e2e module declaration, valid l…
claude 336a3bf
Address review: the session slot is expiry-aware
claude c8ce6eb
Merge branch 'claude/secondary-mcp-local-deploy-jpof9i-stage2' into c…
claude e2a42d3
Merge remote-tracking branch 'origin/main' into claude/secondary-mcp-…
claude 2777578
Address review: state the real rationale for Codex's file-edit path
claude e0fb1c8
rustfmt: wrap the slot-commit line, drop a stray blank line
claude fe06fcb
Address review: honest exit code, mode-aware guidance, escaped snippe…
claude 3b8be95
Address review round 2: safer quoting, stricter remove, backups on re…
claude 6e2951e
Address review round 3: atomic config writes, torn-backup guard, UTF-…
claude e10ebe1
Address review round 4: keep config permissions, merge inline Codex e…
claude d2cafd5
Address review round 5: symlinked configs keep their link, conflictin…
claude bce02f5
Codex setup goes vendor-CLI-first with a file fallback
claude 20d801d
Address review round 6: refuse dangling symlinked configs, honest abs…
claude File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,304 @@ | ||
| # This file was autogenerated by dist: https://axodotdev.github.io/cargo-dist | ||
| # | ||
| # Copyright 2022-2024, axodotdev | ||
| # SPDX-License-Identifier: MIT or Apache-2.0 | ||
| # | ||
| # CI that: | ||
| # | ||
| # * checks for a Git Tag that looks like a release | ||
| # * builds artifacts with dist (archives, installers, hashes) | ||
| # * uploads those artifacts to temporary workflow zip | ||
| # * on success, uploads the artifacts to a GitHub Release | ||
| # | ||
| # Note that the GitHub Release will be created with a generated | ||
| # title/body based on your changelogs. | ||
|
|
||
| name: Release | ||
| permissions: | ||
| "contents": "write" | ||
|
|
||
| # This task will run whenever you push a git tag that looks like a version | ||
| # like "1.0.0", "v0.1.0-prerelease.1", "my-app/0.1.0", "releases/v1.0.0", etc. | ||
| # Various formats will be parsed into a VERSION and an optional PACKAGE_NAME, where | ||
| # PACKAGE_NAME must be the name of a Cargo package in your workspace, and VERSION | ||
| # must be a Cargo-style SemVer Version (must have at least major.minor.patch). | ||
| # | ||
| # If PACKAGE_NAME is specified, then the announcement will be for that | ||
| # package (erroring out if it doesn't have the given version or isn't dist-able). | ||
| # | ||
| # If PACKAGE_NAME isn't specified, then the announcement will be for all | ||
| # (dist-able) packages in the workspace with that version (this mode is | ||
| # intended for workspaces with only one dist-able package, or with all dist-able | ||
| # packages versioned/released in lockstep). | ||
| # | ||
| # If you push multiple tags at once, separate instances of this workflow will | ||
| # spin up, creating an independent announcement for each one. However, GitHub | ||
| # will hard limit this to 3 tags per commit, as it will assume more tags is a | ||
| # mistake. | ||
| # | ||
| # If there's a prerelease-style suffix to the version, then the release(s) | ||
| # will be marked as a prerelease. | ||
| on: | ||
| pull_request: | ||
| push: | ||
| tags: | ||
| - 'imcp2-local**[0-9]+.[0-9]+.[0-9]+*' | ||
|
aterga marked this conversation as resolved.
Resolved
|
||
|
|
||
| jobs: | ||
| # Run 'dist plan' (or host) to determine what tasks we need to do | ||
| plan: | ||
| runs-on: "ubuntu-22.04" | ||
| outputs: | ||
| val: ${{ steps.plan.outputs.manifest }} | ||
| tag: ${{ !github.event.pull_request && github.ref_name || '' }} | ||
| tag-flag: ${{ !github.event.pull_request && format('--tag={0}', github.ref_name) || '' }} | ||
| publishing: ${{ !github.event.pull_request }} | ||
| env: | ||
| GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| steps: | ||
| - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd | ||
| with: | ||
| persist-credentials: false | ||
| submodules: recursive | ||
| - name: Install dist | ||
| # we specify bash to get pipefail; it guards against the `curl` command | ||
| # failing. otherwise `sh` won't catch that `curl` returned non-0 | ||
| shell: bash | ||
| run: "curl --proto '=https' --tlsv1.2 -LsSf https://github.com/axodotdev/cargo-dist/releases/download/v0.31.0/cargo-dist-installer.sh | sh" | ||
| - name: Cache dist | ||
| uses: actions/upload-artifact@b7c566a772e6b6bfb58ed0dc250532a479d7789f | ||
| with: | ||
| name: cargo-dist-cache | ||
| path: ~/.cargo/bin/dist | ||
| # sure would be cool if github gave us proper conditionals... | ||
| # so here's a doubly-nested ternary-via-truthiness to try to provide the best possible | ||
| # functionality based on whether this is a pull_request, and whether it's from a fork. | ||
| # (PRs run on the *source* but secrets are usually on the *target* -- that's *good* | ||
| # but also really annoying to build CI around when it needs secrets to work right.) | ||
| - id: plan | ||
| run: | | ||
| dist ${{ (!github.event.pull_request && format('host --steps=create --tag={0}', github.ref_name)) || 'plan' }} --output-format=json > plan-dist-manifest.json | ||
| echo "dist ran successfully" | ||
| cat plan-dist-manifest.json | ||
| echo "manifest=$(jq -c "." plan-dist-manifest.json)" >> "$GITHUB_OUTPUT" | ||
| - name: "Upload dist-manifest.json" | ||
| uses: actions/upload-artifact@b7c566a772e6b6bfb58ed0dc250532a479d7789f | ||
| with: | ||
| name: artifacts-plan-dist-manifest | ||
| path: plan-dist-manifest.json | ||
|
|
||
| # Build and packages all the platform-specific things | ||
| build-local-artifacts: | ||
| name: build-local-artifacts (${{ join(matrix.targets, ', ') }}) | ||
| # Let the initial task tell us to not run (currently very blunt) | ||
| needs: | ||
| - plan | ||
| if: ${{ fromJson(needs.plan.outputs.val).ci.github.artifacts_matrix.include != null && (needs.plan.outputs.publishing == 'true' || fromJson(needs.plan.outputs.val).ci.github.pr_run_mode == 'upload') }} | ||
| strategy: | ||
| fail-fast: false | ||
| # Target platforms/runners are computed by dist in create-release. | ||
| # Each member of the matrix has the following arguments: | ||
| # | ||
| # - runner: the github runner | ||
| # - dist-args: cli flags to pass to dist | ||
| # - install-dist: expression to run to install dist on the runner | ||
| # | ||
| # Typically there will be: | ||
| # - 1 "global" task that builds universal installers | ||
| # - N "local" tasks that build each platform's binaries and platform-specific installers | ||
| matrix: ${{ fromJson(needs.plan.outputs.val).ci.github.artifacts_matrix }} | ||
| runs-on: ${{ matrix.runner }} | ||
| container: ${{ matrix.container && matrix.container.image || null }} | ||
| env: | ||
| GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| BUILD_MANIFEST_NAME: target/distrib/${{ join(matrix.targets, '-') }}-dist-manifest.json | ||
| permissions: | ||
| "attestations": "write" | ||
| "contents": "read" | ||
| "id-token": "write" | ||
| steps: | ||
| - name: enable windows longpaths | ||
| run: | | ||
| git config --global core.longpaths true | ||
| - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd | ||
| with: | ||
| persist-credentials: false | ||
| submodules: recursive | ||
| - name: Install Rust non-interactively if not already installed | ||
| if: ${{ matrix.container }} | ||
| run: | | ||
| if ! command -v cargo > /dev/null 2>&1; then | ||
| curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y | ||
| echo "$HOME/.cargo/bin" >> $GITHUB_PATH | ||
| fi | ||
| - name: Install dist | ||
| run: ${{ matrix.install_dist.run }} | ||
| # Get the dist-manifest | ||
| - name: Fetch local artifacts | ||
| uses: actions/download-artifact@37930b1c2abaa49bbe596cd826c3c89aef350131 | ||
| with: | ||
| pattern: artifacts-* | ||
| path: target/distrib/ | ||
| merge-multiple: true | ||
| - name: Install dependencies | ||
| run: | | ||
| ${{ matrix.packages_install }} | ||
| - name: Build artifacts | ||
| run: | | ||
| # Actually do builds and make zips and whatnot | ||
| dist build ${{ needs.plan.outputs.tag-flag }} --print=linkage --output-format=json ${{ matrix.dist_args }} > dist-manifest.json | ||
| echo "dist ran successfully" | ||
| - name: Attest | ||
| uses: actions/attest-build-provenance@96278af6caaf10aea03fd8d33a09a777ca52d62f | ||
| with: | ||
| subject-path: "target/distrib/*${{ join(matrix.targets, ', ') }}*" | ||
| - id: cargo-dist | ||
| name: Post-build | ||
| # We force bash here just because github makes it really hard to get values up | ||
| # to "real" actions without writing to env-vars, and writing to env-vars has | ||
| # inconsistent syntax between shell and powershell. | ||
| shell: bash | ||
| run: | | ||
| # Parse out what we just built and upload it to scratch storage | ||
| echo "paths<<EOF" >> "$GITHUB_OUTPUT" | ||
| dist print-upload-files-from-manifest --manifest dist-manifest.json >> "$GITHUB_OUTPUT" | ||
| echo "EOF" >> "$GITHUB_OUTPUT" | ||
|
|
||
| cp dist-manifest.json "$BUILD_MANIFEST_NAME" | ||
| - name: "Upload artifacts" | ||
| uses: actions/upload-artifact@b7c566a772e6b6bfb58ed0dc250532a479d7789f | ||
| with: | ||
| name: artifacts-build-local-${{ join(matrix.targets, '_') }} | ||
| path: | | ||
| ${{ steps.cargo-dist.outputs.paths }} | ||
| ${{ env.BUILD_MANIFEST_NAME }} | ||
|
|
||
| # Build and package all the platform-agnostic(ish) things | ||
| build-global-artifacts: | ||
| needs: | ||
| - plan | ||
| - build-local-artifacts | ||
| runs-on: "ubuntu-22.04" | ||
| env: | ||
| GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| BUILD_MANIFEST_NAME: target/distrib/global-dist-manifest.json | ||
| steps: | ||
| - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd | ||
| with: | ||
| persist-credentials: false | ||
| submodules: recursive | ||
| - name: Install cached dist | ||
| uses: actions/download-artifact@37930b1c2abaa49bbe596cd826c3c89aef350131 | ||
| with: | ||
| name: cargo-dist-cache | ||
| path: ~/.cargo/bin/ | ||
| - run: chmod +x ~/.cargo/bin/dist | ||
| # Get all the local artifacts for the global tasks to use (for e.g. checksums) | ||
| - name: Fetch local artifacts | ||
| uses: actions/download-artifact@37930b1c2abaa49bbe596cd826c3c89aef350131 | ||
| with: | ||
| pattern: artifacts-* | ||
| path: target/distrib/ | ||
| merge-multiple: true | ||
| - id: cargo-dist | ||
| shell: bash | ||
| run: | | ||
| dist build ${{ needs.plan.outputs.tag-flag }} --output-format=json "--artifacts=global" > dist-manifest.json | ||
|
aterga marked this conversation as resolved.
Resolved
|
||
| echo "dist ran successfully" | ||
|
|
||
| # Parse out what we just built and upload it to scratch storage | ||
| echo "paths<<EOF" >> "$GITHUB_OUTPUT" | ||
| jq --raw-output ".upload_files[]" dist-manifest.json >> "$GITHUB_OUTPUT" | ||
| echo "EOF" >> "$GITHUB_OUTPUT" | ||
|
|
||
| cp dist-manifest.json "$BUILD_MANIFEST_NAME" | ||
| - name: "Upload artifacts" | ||
| uses: actions/upload-artifact@b7c566a772e6b6bfb58ed0dc250532a479d7789f | ||
| with: | ||
| name: artifacts-build-global | ||
| path: | | ||
| ${{ steps.cargo-dist.outputs.paths }} | ||
| ${{ env.BUILD_MANIFEST_NAME }} | ||
| # Determines if we should publish/announce | ||
| host: | ||
| needs: | ||
| - plan | ||
| - build-local-artifacts | ||
| - build-global-artifacts | ||
| # Only run if we're "publishing", and only if plan, local and global didn't fail (skipped is fine) | ||
| if: ${{ always() && needs.plan.result == 'success' && needs.plan.outputs.publishing == 'true' && (needs.build-global-artifacts.result == 'skipped' || needs.build-global-artifacts.result == 'success') && (needs.build-local-artifacts.result == 'skipped' || needs.build-local-artifacts.result == 'success') }} | ||
| env: | ||
| GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| runs-on: "ubuntu-22.04" | ||
| outputs: | ||
| val: ${{ steps.host.outputs.manifest }} | ||
| steps: | ||
| - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd | ||
| with: | ||
| persist-credentials: false | ||
| submodules: recursive | ||
| - name: Install cached dist | ||
| uses: actions/download-artifact@37930b1c2abaa49bbe596cd826c3c89aef350131 | ||
| with: | ||
| name: cargo-dist-cache | ||
| path: ~/.cargo/bin/ | ||
| - run: chmod +x ~/.cargo/bin/dist | ||
| # Fetch artifacts from scratch-storage | ||
| - name: Fetch artifacts | ||
| uses: actions/download-artifact@37930b1c2abaa49bbe596cd826c3c89aef350131 | ||
| with: | ||
| pattern: artifacts-* | ||
| path: target/distrib/ | ||
| merge-multiple: true | ||
| - id: host | ||
| shell: bash | ||
| run: | | ||
| dist host ${{ needs.plan.outputs.tag-flag }} --steps=upload --steps=release --output-format=json > dist-manifest.json | ||
| echo "artifacts uploaded and released successfully" | ||
| cat dist-manifest.json | ||
| echo "manifest=$(jq -c "." dist-manifest.json)" >> "$GITHUB_OUTPUT" | ||
| - name: "Upload dist-manifest.json" | ||
| uses: actions/upload-artifact@b7c566a772e6b6bfb58ed0dc250532a479d7789f | ||
| with: | ||
| # Overwrite the previous copy | ||
| name: artifacts-dist-manifest | ||
| path: dist-manifest.json | ||
| # Create a GitHub Release while uploading all files to it | ||
| - name: "Download GitHub Artifacts" | ||
| uses: actions/download-artifact@37930b1c2abaa49bbe596cd826c3c89aef350131 | ||
| with: | ||
| pattern: artifacts-* | ||
| path: artifacts | ||
| merge-multiple: true | ||
| - name: Cleanup | ||
| run: | | ||
| # Remove the granular manifests | ||
| rm -f artifacts/*-dist-manifest.json | ||
| - name: Create GitHub Release | ||
| env: | ||
| PRERELEASE_FLAG: "${{ fromJson(steps.host.outputs.manifest).announcement_is_prerelease && '--prerelease' || '' }}" | ||
| ANNOUNCEMENT_TITLE: "${{ fromJson(steps.host.outputs.manifest).announcement_title }}" | ||
| ANNOUNCEMENT_BODY: "${{ fromJson(steps.host.outputs.manifest).announcement_github_body }}" | ||
| RELEASE_COMMIT: "${{ github.sha }}" | ||
| run: | | ||
| # Write and read notes from a file to avoid quoting breaking things | ||
| echo "$ANNOUNCEMENT_BODY" > $RUNNER_TEMP/notes.txt | ||
|
|
||
| gh release create "${{ needs.plan.outputs.tag }}" --target "$RELEASE_COMMIT" $PRERELEASE_FLAG --title "$ANNOUNCEMENT_TITLE" --notes-file "$RUNNER_TEMP/notes.txt" artifacts/* | ||
|
|
||
| announce: | ||
| needs: | ||
| - plan | ||
| - host | ||
| # use "always() && ..." to allow us to wait for all publish jobs while | ||
| # still allowing individual publish jobs to skip themselves (for prereleases). | ||
| # "host" however must run to completion, no skipping allowed! | ||
| if: ${{ always() && needs.host.result == 'success' }} | ||
| runs-on: "ubuntu-22.04" | ||
| env: | ||
| GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| steps: | ||
| - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd | ||
| with: | ||
| persist-credentials: false | ||
| submodules: recursive | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.