Return GeoIP network along with results - #117
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The API update is consistently applied and covered by representative network tests.
Pull request overview
Extends GeoIP lookups to return the matched network, enabling downstream DNS response scoping.
Changes:
- Return
IpNetalongside country and city results. - Preserve middleware behavior by extracting only the country code.
- Add IPv4 and IPv6 network assertions.
File summaries
| File | Description |
|---|---|
ic-bn-lib/src/geoip.rs |
Adds matched networks to GeoIP results and tests. |
ic-bn-lib/src/http/middleware/request_meta.rs |
Adapts country lookup to the new tuple result. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
frankdavid
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It returns the network with prefix that matched the GeoIP lookup.
This will help DNS GeoIP to scope responses more precisely.