Skip to content

docs: record that a closing keyword binds to one issue - #371

Merged
raymondk merged 1 commit into
mainfrom
infra/closing-keyword-rule
Sep 14, 2026
Merged

raymondk merged 1 commit into
mainfrom
infra/closing-keyword-rule

Conversation

@marc0olo

Copy link
Copy Markdown
Contributor

Summary

#370 was written to close ten issues with a single Closes #360, #361, #362, ... line. It closed #360 only; the other nine stayed open and had to be closed by hand. GitHub binds a closing keyword to one reference and treats the rest of a comma-separated list as plain mentions.

Adds two sentences to the Submitting section of AGENTS.md: repeat the keyword per number, and check afterwards that they all closed.

Why this is worth a rule

The upstream watcher will keep producing batches of issues that one sync PR closes, so this exact shape recurs by design. The failure is silent: the PR merges, the list looks right, and the issues quietly stay open.

A PR closing ten issues with `Closes #360, #361, ...` closed only #360 and left
nine open; the other nine had to be closed by hand. GitHub binds the keyword to
a single reference, so it has to be repeated per number.
@marc0olo
marc0olo requested a review from a team as a code owner August 27, 2026 18:49
@raymondk
raymondk merged commit 65a36be into main Sep 14, 2026
7 checks passed
@raymondk
raymondk deleted the infra/closing-keyword-rule branch September 14, 2026 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants