You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The mini player and the fullscreen player, as the OpenSpec change mini-and-fullscreen-player planned. The maintainer subagent's plan check gave "Verdict: Build" on 49133bf, after five rounds; that commit is c14dba3 after the rebases, which changed none of the plan. The hashes below are the current ones, after the rebases onto ca3360b, 9841b01 and ed1c0b7, which changed none of the plan. The last commit archives the change into the living player spec.
What changed and why
Minimize instead of close. The video screen's top button, "Minimize player", and the back gesture go back to Search and leave playback as it is. PlayerViewModel releases its playback instead of stopping it.
The mini player (MiniPlayer in :feature:player-ui, placed by :app under the back stack): title, channel name, a progress line, play and pause, and a close button. Tapping it reopens the video screen, which goes on with the playback (GO_ON), and so does opening the same video from search. miniPlayerContent decides what it shows.
Fullscreen: dark scheme, landscape on phones, the controls and the system bars hiding 3 s after the last touch while playing and coming back on pause, end, failure or a key, staying while TalkBack is on. The overlays sit inside the system bars' insets, even while the bars hide, and the cutout. Fullscreen is saved, so it outlives the process. FullscreenControls decides.
Playback belongs to the app. The leaving rule moves into PlaybackConnection (appStarted, appStopped, leaveDecision, with pausesOnLeave's four cases). A minimized video holds no picture, so it fetches only its sound.
Rules: AGENTS.md, ADR 0002 (dated note) and architecture.md widen the one-public-composable rule and the player command exception to the mini player, as the maintainer approved.
Design system: the fullscreen and fullscreen_exit glyphs, and DewfallOpacity.DURATION_SCRIM with a token test.
Docs: architecture.md, testing.md's hand checks, and the player spec.
The maintainer's answers
The maintainer answered design.md's "Questions for the maintainer" in Claude Code on November 21, 2026, each with the recommendation:
How the user stops playback once a video is minimized: "Close button (Recommended)", a close button at the end of the mini player, named "Close player", which stops playback and removes the media notification.
The picture while minimized: "Turn it off (Recommended)", as in the background.
Fullscreen controls: "Hide after 3 s (Recommended)", 3 seconds after the last touch while playing, or later when the accessibility setting asks; a tap shows them; they stay while paused, loading, ended or failed.
Widening AGENTS.md's one-public-composable rule and ADR 0002's player command exception to the mini player, with a dated note in ADR 0002: "Yes, widen them (Recommended)".
A paused, minimized video that Android stops in the background loses its mini player and position until Mark as watched and resume position #50: "Accept for now (Recommended)".
The maintainer approved the OpenSpec change mini-and-fullscreen-player at commit ed5d4c0 (3105546 after the rebase onto ca3360b): "Approve (Recommended)". The next commit only records these answers in the plan.
After the approval, 79f8b4c applied the second plan check's findings without changing any answer: fullscreen is saved across the end of the process, so the phone can't stay turned; the leaving rule's configuration-change cases move into leaveDecision; the fullscreen controls stay while TalkBack is on; and the spec gained scenarios and hand checks for these.
The maintainer answered two more questions in Claude Code on November 21, 2026, after the third plan check:
The three user-visible additions made after the approval at ed5d4c0: (a) fullscreen controls stay while TalkBack is on, (b) fullscreen comes back after Android ends the process, waiting for play, (c) a failure in the mini player offers play with no reason, and the video screen says why: "Approve all three (Recommended)".
Whether a tap in fullscreen shows the system bars with the controls, which hide together 3 s later while playing: "Show with controls (Recommended)".
7cea4ad applies the third plan check's finding and answer 7: the title and the control row sit inside the system bar insets that ignore visibility, so no bar ever covers them, and the bars show and hide with the controls.
c14dba3 applies the fourth plan check's findings within answer 3: the fullscreen controls come back whenever the video stops playing (a pause from anywhere, the end, a failure, waiting for data) and stay while a screen reader is on, a tap hides them only while playing, and leaving fullscreen sets portrait.
New dependencies
None. :feature:player-ui adds activity-compose 1.13.0, which :app already ships. :app:dependencies --configuration releaseRuntimeClasspath lists the same 260 artifacts as on main.
Checks
./gradlew spotlessCheck detekt lint test assembleDebug passes.
Pre-push gate on 4dc54ad, on main at ed1c0b7 (the last lines; every commit passed):
PASS commit dd37b38 fix: keep fullscreen's failure Banner clear of the title
PASS commit 4dc54ad docs: archive the mini and fullscreen players change
PASS nothing uncommitted
PASS full build and every test
PASS the build changed no file
PASS: the gate passed.
Emulator test: search then play #46's emulator test, ./gradlew :app:connectedDebugAndroidTest, passes on the Android 17 emulator with this branch: searchThenPlay, 1 test, 0 failures.
Screenshot tests: Screenshot tests in light, dark and large font #45's setup (test: add screenshot tests in light, dark and large font #207) merged first, so 084ee33 adds the mini player's and fullscreen's screenshot tests in its style: internal previews in MiniPlayerPreviews.kt and FullscreenPreviews.kt, @previewTest wrappers in MiniAndFullscreenScreenshots.kt, 21 new images in light, dark, large font, tablet and dynamic color, and the video screen's 12 changed images, which now show the fullscreen button. scripts/scan_screenshot_tests.py passes. The large-font image showed a gap before the exit button, so the times and the seek bar now share a row of their own.
Hand checks, November 21 and 22, 2026:
Android 17 (API 37): minimizing by button, back gesture and double tap; the mini player's pause, play and close (session and notification cleared); its title wrapping and dark-mode text; Search's last result above it, and above the navigation bar after it closes; the keyboard covering it; reopening from it and from search without a restart; the picture off while minimized (21.4 MiB/min open, 1.1 MiB/min minimized); the notification reopening Search with the mini player; leaving early from the video screen and minimized stays paused; process death leaves no mini player; "Don't keep activities" keeps background play. Fullscreen: landscape, bars and controls hide after 3 s, tap toggles, pause, end-of-buffer and a key bring them back, TalkBack keeps them, a 126 px cutout stays clear, exit button and back gesture return to portrait, a network failure shows "Try again" and the exit button, and after process death fullscreen comes back waiting for play.
Android 12L (API 32): minimizing, the mini player playing, reopening from it, fullscreen in landscape with the controls hidden, and back to portrait.
Android 10 (API 29), November 22, on a temporary Pixel 4 AVD, since the machine's own one is off limits: "Minimizing", "Playing" apart from seeking, "Networks" with the network off, "The background" apart from the lock screen and Doze, "The picture in the background" for a 1080p video, "The mini player", "The mini player's layout", "Minimized in the background" (with the back gesture on Search finishing the root activity while it plays, and the notification reopening Search with the mini player), "Stopping", "Live", "Leaving early", "Dismissing", "Coming back", "A notification left behind", "The end in the background", "Failures in the background", "Buttons", and fullscreen's landscape, bars, controls, keys, network failure, cutout, live stream, largest font, notification and the end of the process all passed. Not run there: "A long video", seeking, mobile data only, the lock screen and Doze, the live stream's bytes on mobile data, "Sound", "The screen", "Don't keep activities", the other-way-round rotation and edge swipe in fullscreen, and a short video's end in fullscreen. TalkBack isn't on that image. The archived tasks.md's 6.2 note lists each.
Tablet (Pixel Tablet, API 37): the mini player's full-width layout, fullscreen in landscape, portrait and split screen with black around the video, and a split screen resize while it plays. The accessibility timeout of 60 seconds passed there: the controls hid after about a minute, with no rebuffering.
Foldable (Pixel Fold, API 37): fullscreen unfolded keeps the window's shape, folding goes on in landscape on the outer screen, and leaving fullscreen turns it to portrait.
The temporary AVDs were deleted afterwards. emulator-5554 wasn't touched.
The checks found four bugs, fixed here: fullscreen's and the mini player's text drew black on dark surfaces, a key didn't bring the fullscreen controls back, and closing the mini player left Search without the navigation bar's inset.
Follow-ups
The living requirements "Video details stay private" (already over 500 characters on main) and "The picture turns off while the app can't be seen" exceed OpenSpec's strict length guideline. A docs change can split them.
Android 10 draws the video screen's background black, and hides its minimize button, while the SurfaceView shows a picture. A build of main at ed1c0b7 does the same, so it comes from the video screen, not from this change. It needs an issue of its own.
MainActivity's visibility signal counts one activity. Two MainActivity instances, which only an explicit start of the activity's component makes, such as adb shell am start -n, can leave the picture off until the app goes home and back. The launcher and the notification bring the task to the front and never make a second one. The same was true of the signal before this change.
CodeRabbit
CodeRabbit paused its automatic reviews after e03ca86, the last commit it reviewed, so it hasn't reviewed the later commits, up to the head 4dc54ad. Posting @coderabbitai review would mean replying on GitHub, so nobody asked it to review them. Every comment it posted up to e03ca86 is fixed or declined below.
A link refresh played again after a pause that landed while the new links loaded: resumesAfterRefresh now also needs play on when they arrive, with a test.
Fullscreen's title could push the control row out at a large font: the title is now the only weighted child, so the row keeps its space at the bottom, and only the title's text scrolls. Checked by hand at font scale 2.
Fullscreen's focusable root could be an unnamed TalkBack stop: it takes focus only while no screen reader is on.
The archived proposal's and design's links pointed one folder too high: fixed.
Task 6.2 was ticked although Android 10 and the large-screen checks didn't run: unticked; the notes say what ran.
Fixed in aa4d9e3 and 084ee33: in a narrow window at a large font, fullscreen's times could squeeze the exit button out. The times and the seek bar now share a row that takes only the width the buttons leave.
Fixed in 09af977: holding the seek bar still for 3 seconds hid the controls under the finger. They now don't hide while a finger is held down, with a test.
Fixed in dd37b38 (the reviewer's round 5 asked too): the failure Banner is now laid out between the title and the control row, so a long title at a large font no longer covers it, and the title still shows.
Declined from the first review:
Bounding the mini player's height with a line limit or ellipsis: the design system says titles wrap and are never cut off, and a YouTube title of at most 100 characters stays a few lines at the largest font.
Checklist
OpenSpec change archived, or not needed
docs/architecture.md updated, or the structure of the app didn't change
ADR added for any decision that would be hard to reverse, or there was none (ADR 0002 gets a dated note)
Reviewer
Final verdict: Ready (round 9, on f49c54e; 4dc54ad changes only its two words "in full", which it asked to drop). Rounds 7 to 9 covered the merge check's fixes: the Android 10, tablet, split screen, fold and accessibility timeout checks, task 6.2's note, the testing.md fallbacks and the unused imports. Its questions for the maintainer: on Android 10 the video screen draws a black background and no minimize button while its picture shows, which predates this change (main at ed1c0b7 does the same); is a follow-up issue enough to close#44, and should it get its own issue on the board before merge? And 6.2 is ticked although some Android 10 checks didn't run, as the note records; is that acceptable for closing #44?
It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.
No actionable comments were generated in the recent review.
Walkthrough
The player feature adds a mini player that retains playback when the video screen closes. It adds fullscreen playback with saved state, accessibility-aware controls, and window handling. Playback lifecycle and picture visibility now account for app visibility and active video screens.
Playback connections can look up and release playback IDs and apply app-stop decisions. Picture visibility depends on app visibility and video-screen holds. Playback service refresh behavior and tests cover lifecycle decisions, release, picture holds, and refresh conditions.
Mini player and navigation app/src/main/kotlin/io/github/dewfallapp/navigation/*, app/src/test/kotlin/io/github/dewfallapp/navigation/BackStackTest.kt, feature/player-logic/.../MiniPlayerContent.kt, feature/player-logic/.../StartAction.kt, feature/player-ui/.../MiniPlayer.kt, feature/player-ui/.../PlayerRoute.kt, feature/player-ui/.../PlayerScreen.kt, feature/player-ui/.../PlayerPreviews.kt, feature/player-ui/.../MiniAndFullscreenPreviews.kt, feature/player-ui/.../strings.xml, feature/player-ui/.../PlayerViewModelTest.kt, AGENTS.md, docs/adr/0002-mvi-with-playback-state-outside.md, docs/architecture.md, docs/testing.md, openspec/changes/archive/2026-11-22-mini-and-fullscreen-player/*, openspec/specs/player/spec.md
Navigation shows the mini player when no video screen is open and adjusts bottom insets for its height. The mini player displays playback details and controls. Opening the current video follows existing playback; minimizing removes the video screen without stopping playback. The Feature module architecture rules in AGENTS.md identify the mini-player public-composable exception and its direct player commands. The Playback state outside MVI rule in ADR 0002 records the mini player’s direct commands and playback-state source.
Fullscreen state is saved and restored. Controls respond to playback, touch, keys, and screen-reader status. The fullscreen UI handles playback states, safe-area insets, orientation, and system bars. The Fullscreen requirements in the player spec describe control visibility and timeout behavior.
sequenceDiagram
participant User
participant MiniPlayer
participant PlaybackConnection
participant DewfallNavigation
participant PlayerViewModel
User->>MiniPlayer: Tap the video title
MiniPlayer->>PlaybackConnection: Resolve playback ID with videoOf
MiniPlayer->>DewfallNavigation: Open the resolved VideoId
DewfallNavigation->>PlayerViewModel: Open the video screen
PlayerViewModel->>PlaybackConnection: Match and follow current playback
Loading
Possibly related issues
dewfallapp/dewfall#210 — The open video-screen hand checks include fullscreen landscape and device configurations. The player spec’s Fullscreen display and orientation requirements cover related behavior; the supplied summary reports that some device checks remain unrun.
dewfallapp/dewfall#45 — This issue requires screenshot tests for screens in light, dark, and large-font modes. The PR adds mini-player and fullscreen previews, but the summary says screenshot tests are deferred.
Possibly related PRs
dewfallapp/dewfall#207 — Adds screenshot-test setup for search and video screens. This PR changes the video screen and adds mini-player and fullscreen previews.
dewfallapp/dewfall#209 — Adds a search-to-play test that this PR reports passing. Both PRs exercise playback and navigation from search to video.
Merge Risk: Low · previous review e03ca
Adds the mini and fullscreen players, and playback now continues after the video screen is minimized. A few small issues remain: the mini player's height is unbounded in short windows at large font, a long fullscreen title can overlap the failure banner, and the focusable fullscreen root may be an unnamed TalkBack stop. Some manual device checks and the screenshot tests are still outstanding. None of these should block core playback, so the change is mergeable with follow-up.
Security architecture risk: Minimal · up to e03ca
Minimizing intentionally keeps playback running. The inspected changes preserve playback identity, cleanup, and existing access restrictions; no material new security or failure-containment risk was established.
Retained concerns
No architecture-level concerns identified.
Security review details
Security Blast Radius
inferred — The new mini-player command path affects the application’s retained playback session and current item, not a separate externally exposed controller. Minimization intentionally extends that session’s lifetime, including its existing notification and trusted-controller access.
Trust Boundaries and Controls
observed — The existing session authorization policy remains in place: the app’s own non-legacy controller receives item-setting authority; notification and trusted controllers receive a restricted playback/read command set with no session commands; other controllers are rejected. Playback IDs map to video identities in an in-process UUID-keyed store.
Resilience and Maintainability Implications
observed — Leaving the app cancels a pending start’s play intent and pauses a current item that has not played, except during configuration changes. Successful link refresh checks playback identity and now requires play intent still to be enabled before resuming, preserving an intervening pause.
Pre-merge checks: 3
Check name
Status
Explanation
Title check
The title "feat: add the mini and fullscreen players" follows the conventional commit format required by the title check. It uses the feat type, no scope, and a colon and space. It also matches the ma…
Linked Issues check
Issue #44 asks for a mini player and a fullscreen player. The supplied whole-PR summary shows both. No unmet coding requirement is evident. Source files were not read.
Out of Scope Changes check
Every change group supports the mini player or fullscreen player requested by #44. Rules and docs changes match the maintainer-approved exceptions in AGENTS.md and ADR 0002. No unrelated change is evi…
Full details: Title check
Explanation
The title "feat: add the mini and fullscreen players" follows the conventional commit format required by the title check. It uses the feat type, no scope, and a colon and space. It also matches the main change: a mini player and a fullscreen player.
Full details: Out of Scope Changes check
Explanation
Every change group supports the mini player or fullscreen player requested by #44. Rules and docs changes match the maintainer-approved exceptions in AGENTS.md and ADR 0002. No unrelated change is evident in the whole-PR summary.
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 1 remain after this review.
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 6 remain after this review.
The reason will be displayed to describe this comment to others. Learn more.
Minor · Functional Correctness · Quick win
Bound the mini player height so that Search keeps usable space.
The mini player has no maximum height. Its title has no line limit or overflow setting, and miniPlayerContent passes the item title through without a length limit. A long title can wrap onto many lines and grow the mini player. The mini player sits in an unweighted Box, which the parent Column measures before the weighted NavDisplay. On a short split-screen window at a large font size, the mini player can take all of the remaining height. Search then has no usable area while the mini player is open. The back gesture and the close control still work.
Keep the mini player at a bounded height so that NavDisplay always has usable space. Choose the bound: a title line limit, an ellipsis, or a maximum height. Check the result in a 320 dp high window at the largest font size.
The reason will be displayed to describe this comment to others. Learn more.
Minor · Functional Correctness · Quick win
Resume after a refresh should check current play intent.
refreshLinks records player.playWhenReady when the link fails, before resolution starts. If the app stops before resolution finishes, appStopped pauses an unplayed item. The refresh still passes its ID check, because releaseDrops keeps the current item. refresh then calls play() from the saved flag, so audio can start in the background.
This conflicts with the requirement "A video that hasn't started waits" in openspec/specs/player/spec.md. That requirement says an unstarted video SHALL NOT start in the background. Before calling play(), the refresh path should check the player's current play intent, not the value captured at failure time.
The reason will be displayed to describe this comment to others. Learn more.
Minor · Functional Correctness · Quick win
Give the focusable fullscreen root an accessible name or hide it from TalkBack traversal.
FullscreenBox makes its root focusable at line 171 to receive key events. The root has no label, so TalkBack can stop on it with no spoken name. This stop can appear before the controls when fullscreen is paused.
Add an accessibility label to the root, or exclude it from accessibility traversal. Keep the root focusable so key events still reach onPreviewKeyEvent.
The reason will be displayed to describe this comment to others. Learn more.
Minor · Functional Correctness · Quick win
Bound the title height so the fullscreen controls keep their space.
TitleBox has no line limit on its title or channel text. At large font size with a long title or channel name, the box can use most of the landscape height. Overlays measures TitleBox before ControlRow. The weighted spacer does not reserve space for the controls. ControlRow then receives only the remaining height, which can be zero.
Limit the metadata height. Keep the title and channel readable with a line limit and ellipsis, or use another layout that reserves the control row's height first. The play and exit controls must stay fully visible at large font size.
AGENTS.md requires large-font screenshot tests for screens. Add a large-font case with a long title and channel name for this layout.
See proposal.md for why. What this change builds on, from #42 and #43 and docs/architecture.md's [The player](../../../docs/architecture.md#the-player) and [Navigation](../../../docs/architecture.md#navigation):
The reason will be displayed to describe this comment to others. Learn more.
Minor · Functional Correctness · Quick win
Fix the architecture links after archiving.
Both ../../../docs/architecture.md links resolve under openspec/docs/. Use ../../../../docs/architecture.md for both links so readers can reach the referenced architecture sections.
As per path instructions, check documentation facts and links under AGENTS.md's “Do not invent facts, URLs” rule.
Phase 4's task list ends the player with "Mini player and fullscreen player" ([roadmap](../../../docs/roadmap.md#phase-4-search-and-play)), issue [#44](https://github.com/dewfallapp/dewfall/issues/44). Today the video screen's top button closes the screen and stops playback, so the user can't look for the next video while one plays, and a video can only fill a 16:9 box above its details. The design has both missing sizes: "Mini player on the inbox" and "Player full screen" in [docs/design/screens.md](../../../docs/design/screens.md#player).
The reason will be displayed to describe this comment to others. Learn more.
Minor · Functional Correctness · Quick win
Fix the documentation links for the archive location.
All three ../../../docs/... links resolve under openspec/docs, not the repository's docs directory. Use ../../../../docs/... for the roadmap and design links.
ADR 0004 requires archiving the change in the feature PR. The links must remain usable after that move. As per path instructions, “check facts” in Markdown documentation.
- [x] 6.1 Run every check that the pull request workflow runs: `./gradlew spotlessCheck detekt lint test assembleDebug`. Verify that it passes.
- [x] 6.2 Update docs/testing.md's "Checking the player by hand": drop the sentence that "Don't keep activities" stops background play, change "Stopping" to the mini player's close button, and add checks for minimizing, the mini player, fullscreen and the picture while minimized. Run the whole list that a change to the video area asks for on emulators with Android 10 (API 29), Android 12L (API 32) and Android 17 (API 37), one emulator at a time across the sessions, plus a tablet or resizable emulator for fullscreen on a large screen and split screen. The new checks:
The reason will be displayed to describe this comment to others. Learn more.
Minor · Functional Correctness · Heavy lift
Complete the required hand checks before marking task 6.2 done.
Line 70 says Android 10, tablet, split-screen and fold checks did not run. The PR also reports that the accessibility-timeout check was blocked. Android 12L and Android 17 runs do not complete this task.
Leave task 6.2 unchecked until the remaining required checks run. Record each result and restore the emulator settings.
As per path instructions, docs/testing.md requires the player hand checks on Android 10, Android 12L and the newest Android for changes to playback, video UI, mini player, fullscreen or the visibility signal.
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 3 remain after this review.
The reason will be displayed to describe this comment to others. Learn more.
Minor · Functional Correctness · Quick win
Keep the times from taking the width that the exit button and seek bar need.
In fullscreen, ControlRow lays out the play button, the times, the seek bar, and the exit button in one Row. TimesText has no maximum width. It can take the space that remains after the play button, so on a narrow split-screen window with a large font, the exit button can be squeezed to less than its 48dp minimum. The seek bar can also get no width. The "Fullscreen has its own controls" requirement in openspec/specs/player/spec.md requires both controls. Limit the times to one line that ends with an ellipsis, or give it a bounded width, so the exit button keeps its minimum size and the seek bar keeps some width at the largest font scale in split screen.
- No new host, no new log line, and nothing new leaves the device.
- Rules: AGENTS.md's module and MVI rules and ADR 0002 gain the mini player, a second public composable whose player commands skip intents, which the maintainer approved on November 21, 2026 (design.md's question 4).
- Docs: docs/architecture.md's "Feature modules", "Navigation", "The theme" and "The player", docs/testing.md's hand checks, and the player spec.
- Screenshot tests of the mini player and the fullscreen player need #45's setup. If #45 merges first, this change adds them. If this change merges first, #45 adds them.
The reason will be displayed to describe this comment to others. Learn more.
Minor · Functional Correctness · Heavy lift
Include the fullscreen screenshot tests in this PR.
If this PR merges before #45, this plan defers the fullscreen screenshot tests to a later PR. That leaves the new screen without the required coverage. As per path instructions, CONTRIBUTING.md says screens get screenshot tests in light, dark, and large font.
The reason will be displayed to describe this comment to others. Learn more.
Minor · Functional Correctness · Heavy lift
Keep the long title clear of the failure banner in fullscreen.
In fullscreen, Overlays draws the title after the failure banner. A long title can grow into the banner's area, and its translucent background then covers part of the banner's message and the Try again label. The spec requires the failure message and Try again to stay usable in fullscreen.
Keep the title and the failure banner in separate vertical areas, so the title never draws over the banner. The tap target is not blocked by the title, so the problem is visibility and legibility, not a dead action.
The reason will be displayed to describe this comment to others. Learn more.
Minor · Functional Correctness · Quick win
Keep the seek control visible until the user releases it.
If the user drags the thumb and holds it stationary for three seconds, this timeout removes Overlays while the pointer remains pressed. touches records events, but does not record an active gesture.
Track pressed pointers or slider interaction. Start the inactivity timeout after release or cancellation. Keep the current timeout for idle playback.
This supports the player spec’s “Seeking in fullscreen” scenario. Add a regression case for a held seek gesture. (raw.githubusercontent.com)
- Add the OpenSpec change mini-and-fullscreen-player for #44: minimizing
in place of closing, the mini player, stopping from it, and the
fullscreen player, with the player spec's deltas.
- design.md lists five questions for the maintainer that the docs don't
answer: how to stop playback, the picture while minimized, whether
fullscreen controls hide, widening ADR 0002's player command rule to
the mini player, and a minimized video that Android stops.
- The maintainer chose each recommendation on November 21, 2026, and
approved the change at ed5d4c0. The plan now says so where it said
the answers were pending.
- Save fullscreen in the ViewModel's SavedStateHandle, so a process that
ends in fullscreen can't leave the phone turned to landscape.
- Move the configuration-change test of the leaving rule into
leaveDecision with pausesOnLeave's four cases, through appStarted and
appStopped(changingConfigurations).
- Keep the fullscreen controls while TalkBack is on, say why a tap shows
no system bars, split the cutout rule out of the controls rule, and
add hand checks for process death, fullscreen at the largest font and
the animation.
- Pad the title and the control row with the system bar insets that
ignore visibility, so no bar ever covers them, as AGENTS.md asks, and
show and hide the bars with the controls, as the maintainer chose.
- Record the maintainer's approval of the three additions after the
first approval, name the interface that holds the picture, listen for
touch exploration changes, and say why the privacy scenario keeps its
living name.
- Modify the living requirement on background sound, so its paused
scenario covers the video screen and not the minimized video.
- Show the fullscreen controls whenever the video isn't playing or a
screen reader is on, bring them back on a pause, the end or a
failure, and let a tap hide them only while playing, as Media3's
PlayerView does, with FullscreenControls' pure functions.
- Call BackHandler unconditionally with enabled, as its reference asks.
- Leave fullscreen in portrait instead of a saved orientation, which
large screens ignore, keep the bar icons light on configuration
changes, and handle keys and click labels for the controls.
- Task 2.2 removes the connection's unused pause and its decision with
pausesOnLeave, and changes their callers in the same step.
- Name Media3's opt-in and the events CurrentMediaItemState follows, and
add a hand check for a video that can't decode in the mini player.
- fullscreen and fullscreen_exit from Material Symbols Rounded at commit
10ecc14790, like the other glyphs, for the fullscreen player's buttons.
- DewfallOpacity.DURATION_SCRIM, 0.8, for the fullscreen player's
overlays, with a DesignTokensTest case against tokens.json.
- Minimizing replaces closing: the video screen's button and the back
gesture leave playback as it is, and PlayerViewModel releases its
playback instead of stopping it.
- MiniPlayer shows the playing video under the back stack while no video
screen is on top, opens it again without a restart, and stops it with
its close button. miniPlayerContent decides what it shows.
- A first opening goes on with a playback of the same video (GO_ON).
- Fullscreen, in the dark scheme, landscape on phones, with the controls
and the system bars hiding while the video plays, as
FullscreenControls decides. It is saved, so it outlives the process.
- The leaving rule moves into the connection's appStopped with
leaveDecision, which keeps pausesOnLeave's four cases. The connection's
unused pause, pauseDecision and isKnown go.
- The picture shows only while a video screen holds it, so a minimized
video fetches only its sound.
- architecture.md: the mini player's place under the back stack and its
insets, minimizing and the release rule, the leaving rule in the
connection, the picture holds, and fullscreen's window, back gesture,
layout and controls, with sources checked on November 21, 2026.
- ADR 0002 and AGENTS.md: the mini player is a second public composable
whose player commands skip intents, as the maintainer approved on
November 21, 2026.
- testing.md: hand checks for minimizing, the mini player and fullscreen,
and "Don't keep activities" no longer stops background play.
- The overlays have no Surface, so their text drew in the default black
on the dark box. They now take the dark scheme's onSurface.
- Keys reach onPreviewKeyEvent only through a focused node, so a key
press never brought the controls back. Fullscreen's root is focusable
and takes focus when it shows.
- The bar sits under the screens with no Surface, so its title drew in
the default black on surfaceContainerHigh in dark mode. It now takes
onSurface, and its previews drop the Surface that hid the bug.
- MiniPlayer lays out nothing once it closes, so onSizeChanged never
reported 0 and Search lost the navigation bar's inset. A box around it
now reports 0.
- Add the playing fullscreen and dark Now playing previews, and correct
design.md's timer and opacity names.
…n view
- A refresh of expired links played again if play was on when the link
was refused, even when the app had paused it since, such as by leaving
before the video played. resumesAfterRefresh now also needs play on
when the new links arrive.
- A long title at a large font could push fullscreen's control row out
of the window. The title box now takes only the space the row leaves,
and scrolls there, so nothing is cut off.
- Fullscreen's root takes key focus only while no screen reader is on,
so TalkBack meets no unnamed stop.
- Two weighted children split the leftover height, so the row sat
mid-screen under a short title. The title is now the only weighted
child, SpaceBetween puts the row at the bottom, and a spacer does it
without a title.
- Only the title's text scrolls, inside its box, so the rounded corners
stay whole.
- Fullscreen asks for key focus again when a screen reader turns off.
- architecture.md says a refresh plays only if play is still on.
- In a narrow window at a large font, the times took the width left
after the play button, and squeezed the exit button out. They are now
weighted like the seek bar, so they wrap instead.
- Holding the seek bar still for 3 seconds hid the controls under the
finger, because only pointer events restarted the wait.
hidesAfterTimeout now also needs no finger held down, with a test.
- #45's setup is on main, so the mini player's and fullscreen's previews
become internal previews without @Preview, with Dewfall's own palette,
and get @previewTest wrappers in src/screenshotTest, in light, dark,
large font, tablet and dynamic color. FullscreenPlayer takes
dynamicColor for them.
- The video screen's images change for the fullscreen button.
- The large-font image showed that weighting the times left a gap before
the exit button, so the times and the seek bar now share a row of
their own, which takes only the width the buttons leave.
- FullscreenPlayer.kt and the previews pass detekt's function limit:
the control row moves to FullscreenControlRow.kt, and the previews to
MiniPlayerPreviews.kt and FullscreenPreviews.kt.
- At a large font, a long title box drew over the failure Banner, which
sat in the picture's place. The Banner is now laid out with the
overlays, between the title and the control row, so the title takes
only the space they leave. The failure images are recorded again.
- Move openspec/changes/mini-and-fullscreen-player to the archive and
apply its deltas to the living player spec, whose Purpose now names
the mini and fullscreen players.
- tasks.md records what the hand checks covered and the four bugs they
found, and that Android 10 and the large-screen checks didn't run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #44
The mini player and the fullscreen player, as the OpenSpec change
mini-and-fullscreen-playerplanned. The maintainer subagent's plan check gave "Verdict: Build" on 49133bf, after five rounds; that commit is c14dba3 after the rebases, which changed none of the plan. The hashes below are the current ones, after the rebases onto ca3360b, 9841b01 and ed1c0b7, which changed none of the plan. The last commit archives the change into the living player spec.What changed and why
MiniPlayerin:feature:player-ui, placed by:appunder the back stack): title, channel name, a progress line, play and pause, and a close button. Tapping it reopens the video screen, which goes on with the playback (GO_ON), and so does opening the same video from search.miniPlayerContentdecides what it shows.FullscreenControlsdecides.appStarted,appStopped,leaveDecision, withpausesOnLeave's four cases). A minimized video holds no picture, so it fetches only its sound.DewfallOpacity.DURATION_SCRIMwith a token test.The maintainer's answers
The maintainer answered design.md's "Questions for the maintainer" in Claude Code on November 21, 2026, each with the recommendation:
The maintainer approved the OpenSpec change
mini-and-fullscreen-playerat commit ed5d4c0 (3105546 after the rebase onto ca3360b): "Approve (Recommended)". The next commit only records these answers in the plan.After the approval, 79f8b4c applied the second plan check's findings without changing any answer: fullscreen is saved across the end of the process, so the phone can't stay turned; the leaving rule's configuration-change cases move into
leaveDecision; the fullscreen controls stay while TalkBack is on; and the spec gained scenarios and hand checks for these.The maintainer answered two more questions in Claude Code on November 21, 2026, after the third plan check:
7cea4ad applies the third plan check's finding and answer 7: the title and the control row sit inside the system bar insets that ignore visibility, so no bar ever covers them, and the bars show and hide with the controls.
c14dba3 applies the fourth plan check's findings within answer 3: the fullscreen controls come back whenever the video stops playing (a pause from anywhere, the end, a failure, waiting for data) and stay while a screen reader is on, a tap hides them only while playing, and leaving fullscreen sets portrait.
New dependencies
None.
:feature:player-uiadds activity-compose 1.13.0, which:appalready ships.:app:dependencies --configuration releaseRuntimeClasspathlists the same 260 artifacts as on main.Checks
./gradlew spotlessCheck detekt lint test assembleDebugpasses.Pre-push gate on 4dc54ad, on main at ed1c0b7 (the last lines; every commit passed):
The emulator tests workflow, emulator-tests.yml, dispatched on this branch: run 44949681177 passed on API 29 and API 37 at 5014e61 (https://github.com/dewfallapp/dewfall/actions/runs/44949681177). Run 44960066175 passed on API 29 and API 37 at 4dc54ad (https://github.com/dewfallapp/dewfall/actions/runs/44960066175).
Emulator test: search then play #46's emulator test,
./gradlew :app:connectedDebugAndroidTest, passes on the Android 17 emulator with this branch: searchThenPlay, 1 test, 0 failures.Screenshot tests: Screenshot tests in light, dark and large font #45's setup (test: add screenshot tests in light, dark and large font #207) merged first, so 084ee33 adds the mini player's and fullscreen's screenshot tests in its style: internal previews in MiniPlayerPreviews.kt and FullscreenPreviews.kt, @previewTest wrappers in MiniAndFullscreenScreenshots.kt, 21 new images in light, dark, large font, tablet and dynamic color, and the video screen's 12 changed images, which now show the fullscreen button.
scripts/scan_screenshot_tests.pypasses. The large-font image showed a gap before the exit button, so the times and the seek bar now share a row of their own.Hand checks, November 21 and 22, 2026:
Follow-ups
adb shell am start -n, can leave the picture off until the app goes home and back. The launcher and the notification bring the task to the front and never make a second one. The same was true of the signal before this change.CodeRabbit
CodeRabbit paused its automatic reviews after e03ca86, the last commit it reviewed, so it hasn't reviewed the later commits, up to the head 4dc54ad. Posting
@coderabbitai reviewwould mean replying on GitHub, so nobody asked it to review them. Every comment it posted up to e03ca86 is fixed or declined below.Review of 57643cb, 7 actionable comments. Fixed in 61960ff and b84153b, and in the archive commit 4dc54ad:
resumesAfterRefreshnow also needs play on when they arrive, with a test.Review of e76a5ab, 2 actionable comments:
Review of 2d05c44, 2 actionable comments:
Declined from the first review:
Checklist
Reviewer
Final verdict: Ready (round 9, on f49c54e; 4dc54ad changes only its two words "in full", which it asked to drop). Rounds 7 to 9 covered the merge check's fixes: the Android 10, tablet, split screen, fold and accessibility timeout checks, task 6.2's note, the testing.md fallbacks and the unused imports. Its questions for the maintainer: on Android 10 the video screen draws a black background and no minimize button while its picture shows, which predates this change (main at ed1c0b7 does the same); is a follow-up issue enough to close #44, and should it get its own issue on the board before merge? And 6.2 is ticked although some Android 10 checks didn't run, as the note records; is that acceptable for closing #44?
🤖 Generated with Claude Code