Repository navigation
feat(files): render Markdown previews with a centered outline - #651
Closed
od-studio-webagency wants to merge 1 commit into
Closed
od-studio-webagency wants to merge 1 commit into
od-studio-webagency wants to merge 1 commit into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
Owner
|
Thanks for this. Markdown previews in the file viewer are already under review in #429, which the maintainer has reviewed several times (#669, #670 and #671 were split out of it and have landed), and #616 covers the same ground with images. Closing this as a duplicate to keep the work in one place. If the centered outline is something you'd like to propose on top, please open an issue for it once a preview has landed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Closes #636
#510, #429, #616과 겹치는 미리보기 논의를 연결합니다. 이 초안의 추가 제안은 목차와 읽기 위치 탐색이며, Mermaid나 새 구문 강조 의존성을 넣지 않았습니다.
Validation
generate:types --check,typecheck,build,test:unit통과. 새 preview/TOC 회귀는 1440/390px 밝은·어두운 테마에서 통과했습니다. 기존 파일 열기/뒤로·앞으로/Settings·Add PC 포커스 검사와 모바일 미디어 16개 경우도 통과했습니다.모든 검증은 별도 작업 공간과 소유한 테스트/demo 환경에서 수행했습니다. 사용자의 실행 중 앱·terminal은 변경하지 않았습니다.
화면 증거
개인 대화나 사용자 세션이 아닌, 소유한 테스트/demo 환경의 가상 데이터로 촬영했습니다.