test(chat): pin browser history fixture locale

[devswha]

Change

The chat history browser regression uses English text selectors but let Chromium inherit the PC's language. On a Korean Mac it rendered the empty-chat message in Korean and timed out even though the history was correctly empty.

Create this fixture's browser page with locale: "en-US", matching its selectors and keeping the product's language setting unchanged.

Validation

• Before: Chromium reported ko-KR, the empty state was Korean, and the English locator timed out with zero chat turns.
• After: the entire standalone chat history harness passes on Bun 1.4.2, including history clearing, stale requests and product pane transitions.
• Full local QA tree passed the entire browser lane, including this formerly failing step, along with 1,673 unit and 278 integration tests on Bun 1.4.2.

[coderabbitai]

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

⚙️ Run configuration

• Configuration used: Repository: devswha/herdr-web-ui/.coderabbit.yaml
• Review profile: CHILL
• Plan: Advanced
• Run ID: 84377af6-e87d-4c92-8cc0-16dd6ba6210a

📥 Commits

Reviewing files that changed from the base of the PR and between 1d65074 and 9183b06.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Repository: devswha/herdr-web-ui/.coderabbit.yaml
• Review profile: CHILL
• Plan: Advanced
• Run ID: e34373ae-e02b-4247-bdf3-333ee86cb194

📥 Commits

Reviewing files that changed from the base of the PR and between aca94ee and dcbef74.

📒 Files selected for processing (1)

• scripts/chat-history-browser-qa.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 6 remain after this review.

---

📝 Summary

Summary by CodeRabbit

• Tests
  • Set the browser QA fixture locale to English (US) for consistent text assertions.

Walkthrough

The browser QA fixture now sets its Playwright page locale to en-US. A comment describes the fixture’s language and English text assertions.

Changes

Browser QA Locale

Layer / File(s)	Summary
Set the browser QA page locale scripts/chat-history-browser-qa.ts	The fixture sets the page locale to en-US and adds a comment about language and English text assertions.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Suggested reviewers: haeminway1

Merge Risk: ⚪ Minimal · up to dcbef

The fixture now uses a deterministic English locale for its English assertions; no actionable merge risk remains.

Architecture Summary

Architecture risk: 🔵 Low · up to dcbef

The change affects 1 system.

Changed systems: scripts

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

• observed — scripts (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

• observed — Modified behavior in scripts/chat-history-browser-qa.ts: The fixture adds a comment about language and English text assertions, and sets the new page’s locale to en-US instead of using the browser-default locale.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title clearly and concisely identifies the main change: pinning the browser history fixture locale.
Description check	✅ Passed	The description includes the required Change and Validation sections. It explains the failure, the fix, and the reported test results.

✨ Finishing Touches

📝 Generate docstrings

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

_{Comment @coderabbitai help to get the list of available commands.}

[devswha]

Independent review (merge-own lane).

Classification: test fix. scripts/chat-history-browser-qa.ts is part of the required "Integration and browser" lane (scripts/ci-browser.sh:22), and it failed on any PC whose browser language is not English: the fixture renders in the browser's language while the assertions use English text. It merges because the required browser lane must pass on a non-English maintainer machine. It changes no product code and needs no CHANGELOG entry.

What I checked:

• browser.newPage({ locale: "en-US" }) pins only this fixture's page, and the product's language setting is untouched.
• The pin is what makes it pass: with locale: "ko-KR" instead, the script fails with TimeoutError: waitFor: Timeout 10000ms exceeded.

What I ran (separate worktree, bun run check run bun scripts/chat-history-browser-qa.ts):

• On 1d65074, all five steps PASS (duplicate requests and pane changes, clear while in flight, 409 recovery, reused tool ids, product pane commits).
• Updated with main (now 9183b06): bun run check fast 1715 pass, 0 fail, and the script again passes all five steps. Fast checks and Integration and browser are green on 9183b06. There are no review threads.