Repository navigation
feat(packs): eight more default packs and 21 more instruments: Sonic Pi's samples, a solo cello, an erhu, a steel pan, synth drums, body percussion, glitch kits and sound effects - #45
Merged
Conversation
…Pi's samples, a solo cello, an erhu, a steel pan, synth drums, body percussion, glitch kits and sound effects
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More sounds, chosen for making something good quickly: acoustic leads, sounds with an electronic or textured character, and effects. All are CC0 or the Unlicense, and come from their authors' repositories at pinned commits. The default download grows by about 0.9 GB, to 3.1 GB (1.5 GB on disk); 22 default packs hold 253 instruments.
New default packs:
sonicpi: the samples Sonic Pi ships with, 203 of them in 18 groups (bd sn hat ride drum elec glitch mehackit perc misc vinyl bass ambi tbd guit tabla loop arovane). The Amen and breakbeat loops are left out because they are cut from records.solocello(Karoryfer x Bigcat, bowed and plucked),erhu(long, short, sul tasto) andsteelpan(jSteelDrum, 5 crossfaded layers).synthdrums(FreePats synthesizer percussion, as a kit),body(body percussion, 14 sounds) andzamenhof(Karoryfer's two glitch kits).miscellania: Versilian's sound effects from VSCO 2 CE, 19 groups.Added to existing packs:
Installer changes the mappings needed:
ampeg_sustain=0and open it with a knob, and centrepan=-100with another; without this the cello was silent after a millisecond and hard left.excludeworks for file-name sources too, which is how the Sonic Pi loops are left out.baselets an instrument use a mapping file that a program in another folder includes. That gives the erhu one voice: its programs also play a second unison voice by default, which looks like a slip.s("vinyl_scratch")issonicpi:vinyl:3. Other variation names such asBD5075orC4do not.Corrections recorded in the registry:
Left out, for later pull requests:
The registry test's budget for the default download goes from 3,000 to 3,300 MB. That is the ~1 GB more decided for this change, not a way around the check.
How I checked:
track scratch: vinyl_scratch,track body: clap, stomp...). Itscredits.txtlists all ten packs.cargo xtask ci,cargo xtask sitewith lychee (0 broken links) and the site's Playwright tests pass.