Skip to content

coreinit/thread: OSThreadEntryPointFn and OSCreateThread take void* for arg - #421

Open
capitalistspz wants to merge 2 commits into
devkitPro:masterfrom
capitalistspz:thread-args
Open

coreinit/thread: OSThreadEntryPointFn and OSCreateThread take void* for arg#421
capitalistspz wants to merge 2 commits into
devkitPro:masterfrom
capitalistspz:thread-args

Conversation

@capitalistspz

@capitalistspz capitalistspz commented May 24, 2025

Copy link
Copy Markdown
Contributor

There's no reason for OSThreadEntryPointFn to take const char** when argv uses the value that is char* in OSCreateThread, there's also no reason for params to be char related when they're not type restricted

@capitalistspz capitalistspz changed the title OSThreadEntryPointFn and OSCreateThread take void* for arg coreinit/thread: OSThreadEntryPointFn and OSCreateThread take void* for arg May 24, 2025
@GaryOderNichts

Copy link
Copy Markdown
Contributor

I'm unsure about this PR. The char* obviously doesn't make sense, but changing the signature of OSThreadEntryPointFn would raise compiler errors on all existing projects.

@capitalistspz

capitalistspz commented Sep 10, 2026

Copy link
Copy Markdown
Contributor Author

Better to break them now than later or never, and it at least doesn't cause any logic errors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants