Repository navigation
Conversation
Subtract the panel left/top offset for mouse input as well as touch input when dragging the right or bottom edge.
|
@L33Z22L11 is attempting to deploy a commit to the NuxtLabs Team on Vercel. A member of the Team first needs to authorize it. |
|
👁️🗨️ Review this pull request with grouped, summarized diffs at: raw result💭 analyzed by {
"headSha": "eef094831c6ab77705e5174f08a3da354586a881",
"result": {
"overallSummary": "Small but important bug fix for dock panel resizing: a misplaced parenthesis in the ternary meant mouse-driven resize calculations never subtracted the panel's offset, only touch did, causing panels to jump in size when dragged with a mouse. The fix just wraps the ternary correctly; behavior for touch and size clamping is unchanged.",
"groups": [
{
"key": "fix-resize-offset",
"label": "Fix panel resize offset",
"summary": "Fixes an operator precedence bug where mouse-driven resizing of a dock panel's right/bottom edge failed to subtract the panel's offset (`box.left`/`box.top`), causing the panel to jump in size. The ternary is now parenthesized so both mouse and touch coordinates get the offset subtracted consistently.",
"category": "ui",
"filePaths": [
"packages/hub-ui/src/client/components/dock/DockPanelResizer.vue"
],
"critical": true,
"lineNotes": [
{
"path": "packages/hub-ui/src/client/components/dock/DockPanelResizer.vue",
"side": "additions",
"line": 51,
"text": "Parenthesizing the ternary ensures `box.left` is subtracted for mouse events too, not just touch events, fixing the width jump when dragging the right edge."
},
{
"path": "packages/hub-ui/src/client/components/dock/DockPanelResizer.vue",
"side": "additions",
"line": 64,
"text": "Same fix applied to the bottom edge, subtracting `box.top` for both mouse and touch events."
}
]
}
],
"schemaVersion": 1,
"source": "llm",
"generatedAt": "2026-10-20T12:34:04.830Z",
"model": "vercel-ai-gateway/anthropic/claude-sonnet-5",
"locale": "en"
}
} |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dragging the right or bottom edge of an offset dock panel with a mouse makes the panel jump in size. The ternary expression subtracts the panel offset only for touch events.
Wrap the ternary so mouse coordinates also subtract
box.leftorbox.top. Touch behavior and the size limits stay unchanged. For example, with a 1200px viewport and a panel from x=300 to x=900, the first mouse move at x=900 should keep the width at 50%, but currently sets it to 75%.Validation: five focused checks against the actual resize handler pass, covering mouse and touch input, all edges and corners, the initial drag frame, and size limits. Three checks fail before the fix. The same patch was also verified in a browser with
@devframes/hub-ui@1.2.5.The full repository checks were not run because dependencies are not installed in the local checkout. This change was prepared with AI assistance.