fix(hub-ui): render the macOS Control key symbol - #385
Open
SaKaNa-Y wants to merge 1 commit into
Open
Conversation
◈ PR Lens
Architecture 1 component touched across 3 lanes. Data flow No data-flow sequence changed in this PR. View
Tip Open a diagram on the canvas, then press W or click play to walk through the change one step at a time. 🪧 More tips
Thanks for using PR Lens! It's built by Coldtea, free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The macOS shortcut editor displays the literal text
\u2303 Ctrlbecause Unicode escapes are not interpreted in Vue template text. Replace it with⌃ Ctrlso the Control modifier button shows the intended symbol.Verified the incorrect label in the browser before the change and the corrected symbol afterward.
Validation:
pnpm lintandpnpm knippassed.pnpm test --runpassed, including the build: 135 test files passed, 1,518 tests passed, and 9 skipped.pnpm typecheckpassed.