fix(in-page-channel): connect panels nested in popup windows - #383
Open
SaKaNa-Y wants to merge 1 commit into
Open
fix(in-page-channel): connect panels nested in popup windows#383SaKaNa-Y wants to merge 1 commit into
SaKaNa-Y wants to merge 1 commit into
Conversation
Panel iframes have no opener of their own, so their handshake never reached the inspected page through the popup window's opener. Discover openers across the ancestor chain, deduplicate targets, and cover direct and nested popup handshakes with regression tests.
◈ PR Lens
Architecture 1 component touched across 2 lanes. Data flow
View
Tip Run 🪧 More tips
Thanks for using PR Lens! It's built by Coldtea, free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The A11y Inspector shows "No page connected" when its panel is rendered in a popup, even though it connects in the embedded dock. The panel iframe has no opener of its own; the popup's opener is the inspected page.
Fix
Include each ancestor window's opener in the default in-page channel handshake targets, deduplicating targets and continuing past inaccessible openers. Existing origin checks remain in place. Update the API comments and add handshake/RPC regression coverage for a direct popup and one or two nested panel frames.
Verification
pnpm lint,pnpm knip,pnpm typecheck, andpnpm buildpassed.pnpm test --run: 135 test files passed; 1,521 tests passed and 9 skipped.